IndexCache - getIndexInformation - check reduce index Out Of Bounds
-------------------------------------------------------------------
Key: MAPREDUCE-1915
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1915
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: tasktracker
Affects Versions: 0.20.2
Reporter: Rares Vernica
Priority: Trivial
When checking if the "reduce" index is out of bounds the check should be
info.mapSpillRecord.size() <= reduce
instead of:
info.mapSpillRecord.size() < reduce
Not a big bug since an Out Of Bounds is thrown downstream anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885413#action_12885413 ]
Hadoop QA commented on MAPREDUCE-1915:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448730/MAPREDUCE-1915.patch
against trunk revision 960534.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/286/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/286/console
This message is automatically generated.
> IndexCache - getIndexInformation - check reduce index Out Of Bounds
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1915
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1915
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.22.0
> Reporter: Rares Vernica
> Priority: Trivial
> Fix For: 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.22.0
>
> Attachments: MAPREDUCE-1915.patch
>
>
> When checking if the "reduce" index is out of bounds the check should be
> info.mapSpillRecord.size() <= reduce
> instead of:
> info.mapSpillRecord.size() < reduce
> Not a big bug since an Out Of Bounds is thrown downstream anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rares Vernica updated MAPREDUCE-1915:
-------------------------------------
Status: Patch Available (was: Open)
Affects Version/s: 0.20.1
0.20.3
0.21.0
0.22.0
Fix Version/s: 0.20.3
0.21.0
0.22.0
0.20.2
0.20.1
> IndexCache - getIndexInformation - check reduce index Out Of Bounds
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1915
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1915
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.20.2, 0.20.1, 0.20.3, 0.21.0, 0.22.0
> Reporter: Rares Vernica
> Priority: Trivial
> Fix For: 0.20.3, 0.21.0, 0.22.0, 0.20.2, 0.20.1
>
> Attachments: MAPREDUCE-1915.patch
>
>
> When checking if the "reduce" index is out of bounds the check should be
> info.mapSpillRecord.size() <= reduce
> instead of:
> info.mapSpillRecord.size() < reduce
> Not a big bug since an Out Of Bounds is thrown downstream anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rares Vernica updated MAPREDUCE-1915:
-------------------------------------
Attachment: MAPREDUCE-1915.patch
> IndexCache - getIndexInformation - check reduce index Out Of Bounds
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1915
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1915
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.22.0
> Reporter: Rares Vernica
> Priority: Trivial
> Fix For: 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.22.0
>
> Attachments: MAPREDUCE-1915.patch
>
>
> When checking if the "reduce" index is out of bounds the check should be
> info.mapSpillRecord.size() <= reduce
> instead of:
> info.mapSpillRecord.size() < reduce
> Not a big bug since an Out Of Bounds is thrown downstream anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.