You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/20 19:07:54 UTC
[GitHub] [spark] imback82 opened a new pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
imback82 opened a new pull request #29167:
URL: https://github.com/apache/spark/pull/29167
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, you can specify properties when creating a temporary view. However, the specified properties are not used and can be misleading.
This PR propose to disallow specifying properties when creating temporary views.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To avoid confusion by disallowing specifying unused properties.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, now if you create a temporary view with properties, the operation will fail:
```
scala> sql("CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1")
org.apache.spark.sql.catalyst.parser.ParseException:
Operation not allowed: CREATE TEMPORARY VIEW ... TBLPROPERTIES (property_name = property_value, ...)(line 1, pos 0)
== SQL ==
CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1
^^^
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662975111
**[Test build #126395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126395/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662141018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662819369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661992622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661280057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662819369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661347555
> Hmm, does it mean the specified properties are not used by Spark currently? If users possibly already use it?
Correct, they are not being used for temporary views. Thus, if you run `SHOW TBLPROPERTIES` on temp views, you will always get empty results (and it is being addressed in #29127).
Btw, properties are used for `DataSource` if you do `CREATE TEMPORARY VIEW ... USING`, but not stored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r459212899
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -266,6 +266,16 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-32374: disallow setting properties for CREATE TEMPORARY VIEW") {
+ withTempView("myabcdview") {
+ val e = intercept[AnalysisException] {
Review comment:
Oh because `ParseException` extends `AnalysisException`. I will update this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661334281
**[Test build #126202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit [`8b35497`](https://github.com/apache/spark/commit/8b35497ef4ca333f3bbfed95abd3394c9a117eed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662106995
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662140532
**[Test build #126269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126269/testReport)** for PR 29167 at commit [`4f725c2`](https://github.com/apache/spark/commit/4f725c2b4167dd9eb3f1f48aa06127964cf74253).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661573542
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126202/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662856094
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662858642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29167:
URL: https://github.com/apache/spark/pull/29167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661320057
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126196/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662851583
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126380/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457692814
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2003,6 +2002,17 @@ class DDLParserSuite extends AnalysisTest {
intercept(sql2, "Found duplicate clauses: TBLPROPERTIES")
}
+ test("create temporary view with properties not allowed") {
Review comment:
updated. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662141018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662975712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661339022
Hmm, does it mean the specified properties are not used by Spark currently? If users possibly already use it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661320048
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662106995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661996289
**[Test build #126269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126269/testReport)** for PR 29167 at commit [`4f725c2`](https://github.com/apache/spark/commit/4f725c2b4167dd9eb3f1f48aa06127964cf74253).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r459210115
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -266,6 +266,16 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-32374: disallow setting properties for CREATE TEMPORARY VIEW") {
+ withTempView("myabcdview") {
+ val e = intercept[AnalysisException] {
Review comment:
interesting, the tests pass. Do you know why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662858268
**[Test build #126395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126395/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661572597
**[Test build #126202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit [`8b35497`](https://github.com/apache/spark/commit/8b35497ef4ca333f3bbfed95abd3394c9a117eed).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457688329
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -2003,6 +2002,17 @@ class DDLParserSuite extends AnalysisTest {
intercept(sql2, "Found duplicate clauses: TBLPROPERTIES")
}
+ test("create temporary view with properties not allowed") {
Review comment:
It would be great if we can have a JIRA ID prefix like `SPARK-32374: `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661334714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662851578
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662858642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662819073
**[Test build #126380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126380/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662106497
**[Test build #126268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126268/testReport)** for PR 29167 at commit [`7d8439f`](https://github.com/apache/spark/commit/7d8439f42363a723249df9b2bf1834f283489f8e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662858268
**[Test build #126395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126395/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661996289
**[Test build #126269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126269/testReport)** for PR 29167 at commit [`4f725c2`](https://github.com/apache/spark/commit/4f725c2b4167dd9eb3f1f48aa06127964cf74253).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661992038
**[Test build #126268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126268/testReport)** for PR 29167 at commit [`7d8439f`](https://github.com/apache/spark/commit/7d8439f42363a723249df9b2bf1834f283489f8e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661573525
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661320048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-663041360
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661997237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662107004
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126268/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661334714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661280057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661334281
**[Test build #126202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126202/testReport)** for PR 29167 at commit [`8b35497`](https://github.com/apache/spark/commit/8b35497ef4ca333f3bbfed95abd3394c9a117eed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661573525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662851174
**[Test build #126380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126380/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457833897
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3515,6 +3515,13 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ val properties = ctx.tablePropertyList.asScala.headOption.map(visitPropertyKeyValues)
+ .getOrElse(Map.empty)
+ if (ctx.TEMPORARY != null && !properties.isEmpty) {
+ operationNotAllowed(
+ "CREATE TEMPORARY VIEW ... TBLPROPERTIES (property_name = property_value, ...)", ctx)
Review comment:
I think we should move that check to the parser as well (in a separate PR). If we support view in DS v2, we shouldn't duplicated the check in both v1 and v2 commands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662819073
**[Test build #126380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126380/testReport)** for PR 29167 at commit [`477b696`](https://github.com/apache/spark/commit/477b696ecd2dd75b114809f2b04e36e8a78f2007).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662975712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661329833
Could you fix the UT failure?
```
org.apache.spark.sql.hive.execution.HiveSQLViewSuite.correctly parse CREATE TEMPORARY VIEW statement
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661992038
**[Test build #126268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126268/testReport)** for PR 29167 at commit [`7d8439f`](https://github.com/apache/spark/commit/7d8439f42363a723249df9b2bf1834f283489f8e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661992622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661997237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661610269
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r459209763
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -266,6 +266,16 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-32374: disallow setting properties for CREATE TEMPORARY VIEW") {
+ withTempView("myabcdview") {
+ val e = intercept[AnalysisException] {
Review comment:
parser exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661279371
**[Test build #126196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://github.com/apache/spark/commit/de95968078b2c4c148db9a93f7dbf5394700a878).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457834146
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -266,6 +266,17 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
}
}
+ test("SPARK-32374: disallow setting properties for CREATE TEMPORARY VIEW") {
+ withTempView("myabcdview") {
+ val e = intercept[AnalysisException] {
+ sql("CREATE TEMPORARY VIEW myabcdview TBLPROPERTIES ('a' = 'b') AS SELECT * FROM jt")
+ }
+ assert(e.message.contains(
+ "Operation not allowed: CREATE TEMPORARY VIEW ... " +
+ "TBLPROPERTIES (property_name = property_value, ...)"))
Review comment:
how about: `Operation not allowed: TBLPROPERTIES can't coexist with CREATE TEMPORARY VIEW`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457632275
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3515,6 +3515,13 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ val properties = ctx.tablePropertyList.asScala.headOption.map(visitPropertyKeyValues)
+ .getOrElse(Map.empty)
+ if (ctx.TEMPORARY != null && !properties.isEmpty) {
+ operationNotAllowed(
+ "CREATE TEMPORARY VIEW ... TBLPROPERTIES (property_name = property_value, ...)", ctx)
Review comment:
This can be moved to `CreateViewCommand` if that is a better place to check this: https://github.com/apache/spark/blob/fe07521c9efd9ce0913eee0d42b0ffd98b1225ec/sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala#L80-L85
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661319868
**[Test build #126196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://github.com/apache/spark/commit/de95968078b2c4c148db9a93f7dbf5394700a878).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-662851578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29167: [SPARK-32374][SQL] Disallow setting properties when creating temporary views
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29167:
URL: https://github.com/apache/spark/pull/29167#issuecomment-661279371
**[Test build #126196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126196/testReport)** for PR 29167 at commit [`de95968`](https://github.com/apache/spark/commit/de95968078b2c4c148db9a93f7dbf5394700a878).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org