[GitHub] [fineract] adamsaghy commented on a diff in pull request #3195: [FINERACT-1926] POST API for asset externalization

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3195:
URL: https://github.com/apache/fineract/pull/3195#discussion_r1201929322


##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransfer.java:
##########
@@ -51,8 +49,8 @@ public class ExternalAssetOwnerTransfer extends AbstractAuditableWithUTCDateTime
     @Column(name = "status", length = 50)
     private String status;
 
-    @Column(name = "purchase_price_ratio", precision = 19, scale = 6)
-    private BigDecimal purchasePriceRatio;
+    @Column(name = "purchase_price_ratio", length = 20)

Review Comment:
   20 is too short. it can go with 50



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org