You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/03 11:47:42 UTC

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #35: [hotfix] Let FileStore assign key/value/partition type directly to StoreSink to avoid serialization error caused by incorrect projection

JingsongLi commented on a change in pull request #35:
URL: https://github.com/apache/flink-table-store/pull/35#discussion_r818578438



##########
File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java
##########
@@ -58,15 +52,11 @@
 
     public FileStoreSource(
             FileStore fileStore,
-            RowType rowType,
-            int[] partitions,
             int[] primaryKeys,

Review comment:
       Maybe we can use `boolean keyAsRecord` instead primaryKeys?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org