You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/12 13:18:08 UTC

[GitHub] [hive] mbathori-cloudera opened a new pull request #2786: HIVE-25686: UDFSpace result length calculation is incorrect after HADOOP-17901 and HADOOP-17905

mbathori-cloudera opened a new pull request #2786:
URL: https://github.com/apache/hive/pull/2786


   ### What changes were proposed in this pull request?
   After the application of HADOOP-17901 and HADOOP-17905 they changed the backing array increment logic which is causing issues in the UDFSpace class.
   
   
   ### Why are the changes needed?
   The previous `result.getBytes().length` is returning incorrect size which is causing error in the result output. By changing this method call to `result.getLength()` the size calculation is correct again any the original behaviour is restored.
   
   Example of the UDFSpace behaviour with the different method calls:
   ```
   space parameter - 11
   result.getBytes().length - 0
   result.getLength() - 0
   
   space parameter - 12
   result.getBytes().length - 11
   result.getLength() - 11
   
   space parameter - 13
   result.getBytes().length - 16
   result.getLength(): 12
   
   space parameter - 14
   result.getBytes().length - 16
   result.getLength() - 13
   ```
   Note that the issue is only present whit Hadoop version that contains HADOOP-17901 and HADOOP-17905.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   The change was tested on live cluster and also in the new qtest that was introduced in the scope of this patch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] zabetak closed pull request #2786: HIVE-25686: UDFSpace result length calculation is incorrect after HADOOP-17901 and HADOOP-17905

Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #2786:
URL: https://github.com/apache/hive/pull/2786


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org