You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/04 13:03:32 UTC

[GitHub] [iotdb] LeicongLi opened a new pull request #3910: [WIP] Add API executeStatement

LeicongLi opened a new pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910


   Add function `executeStatement` Sesssion and SessionPool, referring to java.sql.Statement#execute(java.lang.String).
   
   Need help to point out how to test. 
   
   Ticket link
   https://issues.apache.org/jira/browse/IOTDB-1088
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #3910: [WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-912977823


   
   [![Coverage Status](https://coveralls.io/builds/42656774/badge)](https://coveralls.io/builds/42656774)
   
   Coverage increased (+0.01%) to 67.242% when pulling **b66002d6b658547680c6064e5854558f359ff728 on LeicongLi:executeStatement_api** into **9931149fb2e8e7ddec8187539d9940869edd1a7a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou edited a comment on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-913443669


   Hi, I checked the execute(String sql) method on IoTDB JDBC. It seems that it keeps a static ResultSet in this class. 
   I think we should do the same thing.
   
   https://github.com/apache/iotdb/blob/3333f3b2a6a5035b7f42a33dd23b3e841b0768b1/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java#L251-L287
   
   I also checked the clickhouse and shardingsphere JDBC code and they all keep the ResultSet.
   
   IOTDB-1088 also states
   ```
   You must then use the methods * <code>getSessionDataSet</code> to retrieve the result.
   ```
   Therefore, I think we also need a method `getSessionDataSet`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-912977823


   
   [![Coverage Status](https://coveralls.io/builds/42665453/badge)](https://coveralls.io/builds/42665453)
   
   Coverage increased (+0.2%) to 67.403% when pulling **9ff3db35f1c675030092119273f452323e67d812 on LeicongLi:executeStatement_api** into **9931149fb2e8e7ddec8187539d9940869edd1a7a on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] LeicongLi commented on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
LeicongLi commented on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-913910383


   > Hi, I checked the execute(String sql) method on IoTDB JDBC. It seems that it keeps a static ResultSet in this class.
   > I think we should do the same thing.
   > 
   > https://github.com/apache/iotdb/blob/3333f3b2a6a5035b7f42a33dd23b3e841b0768b1/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java#L251-L287
   > 
   > I also checked the clickhouse and shardingsphere JDBC code and they all keep the ResultSet.
   > 
   > [IOTDB-1088](https://issues.apache.org/jira/browse/IOTDB-1088) also states
   > 
   > ```
   > You must then use the methods * <code>getSessionDataSet</code> to retrieve the result.
   > ```
   > 
   > Therefore, I think we also need a method `getSessionDataSet`.
   
   Thanks.
   Will reopen the PR when the changes are made.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] LeicongLi closed pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
LeicongLi closed pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-913443669


   Hi, I checked the execute(String sql) method on IoTDB JDBC. It seems that it keeps a static ResultSet in this class. 
   I think we should do the same thing.
   
   https://github.com/apache/iotdb/blob/3333f3b2a6a5035b7f42a33dd23b3e841b0768b1/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBStatement.java#L251-L287
   
   I also checked the clickhouse and shardingsphere JDBC code and they all keep the ResultSet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-912977823


   
   [![Coverage Status](https://coveralls.io/builds/42681989/badge)](https://coveralls.io/builds/42681989)
   
   Coverage decreased (-0.01%) to 67.363% when pulling **6b7ffb594c9ed285311a77ac8eae8007fcb950ed on LeicongLi:executeStatement_api** into **3333f3b2a6a5035b7f42a33dd23b3e841b0768b1 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] HTHou commented on pull request #3910: [IOTDB-1088][WIP] Add API executeStatement

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3910:
URL: https://github.com/apache/iotdb/pull/3910#issuecomment-913174769


   > Need help to point out how to test.
   
   Thanks for your contribution!
   To add test cases, you can see the following IT classes.
   https://github.com/apache/iotdb/blob/master/session/src/test/java/org/apache/iotdb/session/IoTDBSessionSimpleIT.java
   https://github.com/apache/iotdb/blob/master/session/src/test/java/org/apache/iotdb/session/pool/SessionPoolTest.java
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org