You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@karaf.apache.org by dieder <di...@ratshome.net> on 2023/04/03 06:32:28 UTC
Re: Patch for stopping karaf
Hi,
I'd love to create a Jira ticket, but I cannot seem to get a Jira
account, so I cannot do that.
kind regards
Dieder Timmers
Jean-Baptiste Onofré schreef op 2023-03-31 07:37:
> Hi,
>
> Yes, that's weird: we might have a regression here as the
> karaf.shutdown.port.file property should be commented by default.
>
> Can you please create a Jira, I will fix that.
>
> Regards
> JB
>
> On Wed, Mar 29, 2023 at 3:14 PM dieder <di...@ratshome.net> wrote:
>>
>> Hi,
>>
>> I could be wrong but looking at the code a bit more and downloading
>> the
>> karaf 4.4.3 binary distribution the default setting for the karaf
>> shutdown is using loopback.
>> the config.properties still defines the property:
>> karaf.shutdown.port.file
>> The default configuration results in the creation of a listening
>> loopback shutdown port. Shouldn't we change the default configuration
>> to
>> use the PID. I've tested this and it works correctly if I remove the
>> karaf.shutdown.port.file property.
>>
>> kind regards
>> Dieder Timmers
>>
>>
>>
>> Jean-Baptiste Onofré schreef op 2023-03-29 08:48:
>> > Hi,
>> >
>> > some info:
>> > 1. for security reason, the command loopback port has been disabled
>> > while ago. It now use the PID.
>> > 2. which version are you using?
>> >
>> > Regards
>> > JB
>> >
>> > On Mon, Mar 27, 2023 at 11:50 AM dieder <di...@ratshome.net> wrote:
>> >>
>> >> Hi All,
>> >>
>> >> Recently I restarted using Karaf. We got an old project and started
>> >> upgrading it.
>> >> Now I think I've discovered a bug in shutting down Karaf from the
>> >> loopback port. Sometimes Karaf does not stop after issuing the stop
>> >> command. I've analyzed it and created a fix. Now I'd like to follow
>> >> the
>> >> correct path for submitting a Jira issue and after that al pull
>> >> request.
>> >> However I cannot seem to get approved for the Jira. I've requested
>> >> access last week and still no response.
>> >> What is the best way forward, retry to get on jira or create a pull
>> >> request for the fix (without an issue that feels ugly).
>> >>
>> >> kind regards
>> >> Dieder Timmers
Re: Patch for stopping karaf
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
No worries, I will create one for you.
Regards
JB
On Mon, Apr 3, 2023 at 8:32 AM dieder <di...@ratshome.net> wrote:
>
> Hi,
>
> I'd love to create a Jira ticket, but I cannot seem to get a Jira
> account, so I cannot do that.
>
> kind regards
> Dieder Timmers
>
> Jean-Baptiste Onofré schreef op 2023-03-31 07:37:
> > Hi,
> >
> > Yes, that's weird: we might have a regression here as the
> > karaf.shutdown.port.file property should be commented by default.
> >
> > Can you please create a Jira, I will fix that.
> >
> > Regards
> > JB
> >
> > On Wed, Mar 29, 2023 at 3:14 PM dieder <di...@ratshome.net> wrote:
> >>
> >> Hi,
> >>
> >> I could be wrong but looking at the code a bit more and downloading
> >> the
> >> karaf 4.4.3 binary distribution the default setting for the karaf
> >> shutdown is using loopback.
> >> the config.properties still defines the property:
> >> karaf.shutdown.port.file
> >> The default configuration results in the creation of a listening
> >> loopback shutdown port. Shouldn't we change the default configuration
> >> to
> >> use the PID. I've tested this and it works correctly if I remove the
> >> karaf.shutdown.port.file property.
> >>
> >> kind regards
> >> Dieder Timmers
> >>
> >>
> >>
> >> Jean-Baptiste Onofré schreef op 2023-03-29 08:48:
> >> > Hi,
> >> >
> >> > some info:
> >> > 1. for security reason, the command loopback port has been disabled
> >> > while ago. It now use the PID.
> >> > 2. which version are you using?
> >> >
> >> > Regards
> >> > JB
> >> >
> >> > On Mon, Mar 27, 2023 at 11:50 AM dieder <di...@ratshome.net> wrote:
> >> >>
> >> >> Hi All,
> >> >>
> >> >> Recently I restarted using Karaf. We got an old project and started
> >> >> upgrading it.
> >> >> Now I think I've discovered a bug in shutting down Karaf from the
> >> >> loopback port. Sometimes Karaf does not stop after issuing the stop
> >> >> command. I've analyzed it and created a fix. Now I'd like to follow
> >> >> the
> >> >> correct path for submitting a Jira issue and after that al pull
> >> >> request.
> >> >> However I cannot seem to get approved for the Jira. I've requested
> >> >> access last week and still no response.
> >> >> What is the best way forward, retry to get on jira or create a pull
> >> >> request for the fix (without an issue that feels ugly).
> >> >>
> >> >> kind regards
> >> >> Dieder Timmers