You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2017/10/19 00:59:47 UTC
[1/2] kudu git commit: Add missing comma in Impala CREATE TABLE
statement
Repository: kudu
Updated Branches:
refs/heads/master bba425e8d -> 43a64f8bf
Add missing comma in Impala CREATE TABLE statement
When the /table page was converted to use a Mustache template, a comma
got dropped from the generated SQL statement.
Change-Id: I699616634421eefcbfa4582130fdde098cbfd421
Reviewed-on: http://gerrit.cloudera.org:8080/8321
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/c60990c2
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/c60990c2
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/c60990c2
Branch: refs/heads/master
Commit: c60990c2754b8239cf4e8284781a794841feff20
Parents: bba425e
Author: Todd Lipcon <to...@apache.org>
Authored: Wed Oct 18 14:51:15 2017 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Wed Oct 18 23:36:34 2017 +0000
----------------------------------------------------------------------
www/table.mustache | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/c60990c2/www/table.mustache
----------------------------------------------------------------------
diff --git a/www/table.mustache b/www/table.mustache
index 575d3fc..734f084 100644
--- a/www/table.mustache
+++ b/www/table.mustache
@@ -125,7 +125,7 @@ under the License.
{{! Unusual formatting below because <pre> preserves whitespace in the output. }}
<pre><code>CREATE EXTERNAL TABLE `{{name}}` STORED AS KUDU
TBLPROPERTIES(
- 'kudu.table_name' = '{{name}}'
+ 'kudu.table_name' = '{{name}}',
'kudu.master_addresses' = '{{master_addresses}}')</code></pre>
<h3>Tasks</h3>
[2/2] kudu git commit: log_block_manager: fix Status::Aborted()
message
Posted by ad...@apache.org.
log_block_manager: fix Status::Aborted() message
Updates the returned status of various calls in log_block_manager.cc
that would previously report incorrect substitution strings, e.g.:
Aborted: container $0 is read-only: /tmp/run_tha_testDcsmkj/test-tmp/tablet_server-test.TabletServerTest.TestDiskFailure.1508130389020340-2609/TabletServerTest-fsroot/data-1/data/462b2facc42d4b85a95b1153dda73095
Change-Id: I21bfd624e7414927044e2a23010ff1f888ff1cb3
Reviewed-on: http://gerrit.cloudera.org:8080/8282
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/43a64f8b
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/43a64f8b
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/43a64f8b
Branch: refs/heads/master
Commit: 43a64f8bf43721539a8b82789eb7fb44547638e8
Parents: c60990c
Author: Andrew Wong <aw...@cloudera.com>
Authored: Mon Oct 16 11:03:34 2017 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Thu Oct 19 00:59:28 2017 +0000
----------------------------------------------------------------------
src/kudu/fs/log_block_manager.cc | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/43a64f8b/src/kudu/fs/log_block_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/fs/log_block_manager.cc b/src/kudu/fs/log_block_manager.cc
index 1b489b8..da9b49b 100644
--- a/src/kudu/fs/log_block_manager.cc
+++ b/src/kudu/fs/log_block_manager.cc
@@ -704,7 +704,8 @@ Status LogBlockContainer::Open(LogBlockManager* block_manager,
if (metadata_size < pb_util::kPBContainerMinimumValidLength &&
data_size == 0) {
report->incomplete_container_check->entries.emplace_back(common_path);
- return Status::Aborted("orphaned empty metadata and data files $0");
+ return Status::Aborted(Substitute("orphaned empty metadata and data files $0",
+ common_path));
}
}
@@ -1220,9 +1221,8 @@ Status LogBlockDeletionTransaction::CommitDeletedBlocks(std::vector<BlockId>* de
}
if (!first_failure.ok()) {
- first_failure = first_failure.CloneAndPrepend(strings::Substitute("only deleted $0 blocks, "
- "first failure",
- deleted->size()));
+ first_failure = first_failure.CloneAndPrepend(Substitute("only deleted $0 blocks, "
+ "first failure", deleted->size()));
}
deleted_blocks_.clear();
return first_failure;
@@ -1328,7 +1328,8 @@ Status LogWritableBlock::Abort() {
block_length_);
}
}
- return Status::Aborted("container $0 is read-only", container_->ToString());
+ return Status::Aborted(Substitute("container $0 is read-only",
+ container_->ToString()));
}
// Close the block and then delete it. Theoretically, we could do nothing