You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ning Zhang (JIRA)" <ji...@apache.org> on 2010/07/17 02:29:50 UTC

[jira] Commented: (HIVE-1469) replace isArray() calls and remove LOG.isInfoEnabled() in Operator.forward()

    [ https://issues.apache.org/jira/browse/HIVE-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889433#action_12889433 ] 

Ning Zhang commented on HIVE-1469:
----------------------------------

+1.
Will commit if tests pass. 

> replace isArray() calls and remove LOG.isInfoEnabled() in Operator.forward()
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-1469
>                 URL: https://issues.apache.org/jira/browse/HIVE-1469
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>            Priority: Minor
>         Attachments: hive-1469.1.patch
>
>
> Small changes:
> In my profiling, isArray() is kind of expensive, we should avoid to call it. 
> Also LOG.isInfoEnabled() is called in every operator's forward() method. We should only call it once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.