You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Julian Sedding (Jira)" <ji...@apache.org> on 2022/08/10 15:57:00 UTC

[jira] [Created] (OAK-9897) SplitPersistence: FileReaper cannot finish cleanup

Julian Sedding created OAK-9897:
-----------------------------------

             Summary: SplitPersistence: FileReaper cannot finish cleanup
                 Key: OAK-9897
                 URL: https://issues.apache.org/jira/browse/OAK-9897
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: segment-tar
    Affects Versions: 1.44.0
            Reporter: Julian Sedding
            Assignee: Julian Sedding


When running revision compaction (aka GC) on a setup with split persistence, it is possible that the "cleanup" phase identifies files from the read-only part of the persistence as redundant and submits them to the {{FileReaper}} for deletion.

However, the delete method of the {{SplitSegmentArchiveManager}} is implemented to return "false" when attempting the deletion of a file from the read-only persistence (which I would argue is correct). The {{FileReaper}} then re-adds the offending file to its queue in order to retry deleting it. Of course this fails again and so it can never finish and logs warnings for the files it cannot delete.

It should be possible to prevent deletion of read-only files in the first place. In fact, I think there is no need to mark and sweep them at all.

cc [~adulceanu]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)