You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vrozov <gi...@git.apache.org> on 2018/04/23 21:05:08 UTC

[GitHub] drill issue #1236: DRILL-6347: Inconsistent method name "field".

Github user vrozov commented on the issue:

    https://github.com/apache/drill/pull/1236
  
    IMO, neither `append` or `appendField` is a good choice (otherwise it is necessary to change `startNode/endNode` to `appendStart/EndNode`). It is either `field` or `visitField` and should follow visitor design pattern. It may be also good to change `listField` to the same name used for `Boolean` and `String`.


---