You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/10/23 08:16:12 UTC
[PR] branch-3.1: [fix](ci) Fix the macOS unit test job [doris-thirdparty]
airborne12 opened a new pull request, #427:
URL: https://github.com/apache/doris-thirdparty/pull/427
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The macOS jobs of the CI of clucene-3.1 do not pass, independent of the code that is changed:
- The macOS unit test job runs on `macos-12`, a runner image that GitHub has retired, so the job stays queued forever. It now uses `macos-15`, like the macOS build job and the other branches.
- `TestStandard95.cpp` defines a global `std::vector<std::string> tokens` and `TestTermVectorsReader.cpp` another one of a different type. With libstdc++ the type of the first one is part of the symbol name (`tokens[abi:cxx11]`), with libc++ both are just `_tokens`, so on macOS cl_test fails to link with "duplicate symbol '_tokens'". The first one is made `static`.
### Release note
None
### Check List (For Author)
- Test: No need to test (CI configuration and test code only)
- Not run on macOS (not available here); cl_test builds and passes on Linux with g++ and clang.
- Behavior changed: No
- Does this need documentation: No
Note: the unit test of the macOS job only passes together with #422 (the pick of #421). Before it, `testPFOR.cpp` includes `for/vp4.h` through the include path `src/ext/*`, which the CMake of the macOS runner does not expand, and the test does not compile (on any platform whose CMake quotes that path). #422 removes that dependency. This change was checked on top of #422.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-3.1: [fix](ci) Fix the macOS unit test job [doris-thirdparty]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #427:
URL: https://github.com/apache/doris-thirdparty/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org