You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/10/23 05:18:54 UTC
[GitHub] [incubator-echarts] pissang commented on issue #11458:
pieselectchange event handler default data.seriesId value has extra
whitespace character
pissang commented on issue #11458: pieselectchange event handler default data.seriesId value has extra whitespace character
URL: https://github.com/apache/incubator-echarts/issues/11458#issuecomment-545271042
It's a special character `\0` to avoid generated id conflicts with user-given id. We can also verify if the id is auto-generated in the inner code by simply checking this character.
The code is in https://github.com/apache/incubator-echarts/blob/master/src/util/model.js#L290
The downside of this solution is it may cause confusion if developers want to use this auto-generated id. We can have a further discussion about it under this issue @100pah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org