[GitHub] [flink] XComp commented on a diff in pull request #21873: [FLINK-30921][ci] Adds mirrors instead of relying on a single source for Ubuntu packages

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #21873:
URL: https://github.com/apache/flink/pull/21873#discussion_r1155699896


##########
tools/azure-pipelines/e2e-template.yml:
##########
@@ -98,6 +98,19 @@ jobs:
 
         echo "Free up disk space"
         ./tools/azure-pipelines/free_disk_space.sh
+        
+        # the APT mirrors access is based on a proposal from https://github.com/actions/runner-images/issues/7048#issuecomment-1419426054
+        echo "Configure APT mirrors"
+        mirror_file_path="/etc/apt/mirrors.txt"
+        default_ubuntu_mirror_url="http://azure.archive.ubuntu.com/ubuntu/"
+        
+        # add Azure's Ubuntu mirror as a top-priority source
+        echo -e "${default_ubuntu_mirror_url}\tpriority:1" | sudo tee ${mirror_file_path}
+        
+        # use other mirrors as a fallback option
+        curl http://mirrors.ubuntu.com/mirrors.txt | sudo tee --append ${mirror_file_path}

Review Comment:
   Interesting point. Just to understand that: It makes us vulnerable because we're relying on `mirrors.ubuntu.com/mirrors.txt`? What about specifying a fixed list of mirrors ourselves instead of relying on an external service?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org