You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/21 10:01:06 UTC
[GitHub] [shardingsphere] penghuazhou opened a new pull request #13723: 修复缺陷#13621
penghuazhou opened a new pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723
Fixes #13621.
Changes proposed in this pull request:
1、Change the enum PostgreSQLMessageSeverityLevel to a class, refactor each element to String.
2、Change the first parameter's type of org.apache.shardingsphere.db.protocol.postgresql.packet.generic.PostgreSQLErrorResponsePacket#newBuilder to String, so that we can pass the constants or severity directly to the method and no need to valueOf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13723: Fixes #13621
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723#issuecomment-975137419
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13723](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6023bf3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/bcfc0524a19bcd0b6a095f3d342fa2d3cf709495?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcfc052) will **decrease** coverage by `0.01%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13723 +/- ##
============================================
- Coverage 63.45% 63.43% -0.02%
Complexity 1699 1699
============================================
Files 2748 2748
Lines 40940 40941 +1
Branches 6987 6988 +1
============================================
- Hits 25977 25972 -5
- Misses 12991 12997 +6
Partials 1972 1972
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../command/generic/OpenGaussErrorResponsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYi9wcm90b2NvbC9vcGVuZ2F1c3MvcGFja2V0L2NvbW1hbmQvZ2VuZXJpYy9PcGVuR2F1c3NFcnJvclJlc3BvbnNlUGFja2V0LmphdmE=) | `60.86% <0.00%> (ø)` | |
| [...resql/constant/PostgreSQLMessageSeverityLevel.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMTWVzc2FnZVNldmVyaXR5TGV2ZWwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../packet/generic/PostgreSQLErrorResponsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvZ2VuZXJpYy9Qb3N0Z3JlU1FMRXJyb3JSZXNwb25zZVBhY2tldC5qYXZh) | `75.36% <100.00%> (ø)` | |
| [...end/postgresql/err/PostgreSQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9lcnIvUG9zdGdyZVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `52.17% <100.00%> (ø)` | |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...xt/admin/mysql/executor/ShowDatabasesExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL215c3FsL2V4ZWN1dG9yL1Nob3dEYXRhYmFzZXNFeGVjdXRvci5qYXZh) | `87.50% <0.00%> (-5.36%)` | :arrow_down: |
| [...ere/infra/parser/sql/SQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wYXJzZXIvc3FsL1NRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...re/infra/parser/ShardingSphereSQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wYXJzZXIvU2hhcmRpbmdTcGhlcmVTUUxQYXJzZXJFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/infra/parser/cache/SQLStatementCacheBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wYXJzZXIvY2FjaGUvU1FMU3RhdGVtZW50Q2FjaGVCdWlsZGVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
| [...ra/parser/sql/SQLStatementParserEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wYXJzZXIvc3FsL1NRTFN0YXRlbWVudFBhcnNlckVuZ2luZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/shardingsphere/pull/13723/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bcfc052...6023bf3](https://codecov.io/gh/apache/shardingsphere/pull/13723?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] penghuazhou commented on pull request #13723: Fixes #13621
Posted by GitBox <gi...@apache.org>.
penghuazhou commented on pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723#issuecomment-975038703
> [TeslaCN](/TeslaCN)
@TeslaCN，I fix it now，please review again，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #13723: Fixes #13621
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723#discussion_r753956475
##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/constant/PostgreSQLMessageSeverityLevel.java
##########
@@ -22,29 +22,29 @@
*
* @see <a href="https://www.postgresql.org/docs/12/runtime-config-logging.html#RUNTIME-CONFIG-SEVERITY-LEVELS">Table 19.2. Message Severity Levels</a>
*/
-public enum PostgreSQLMessageSeverityLevel {
+public class PostgreSQLMessageSeverityLevel {
Review comment:
Please add `final` modifier and `@NoArgsConstructor(access = AccessLevel.PRIVATE)` here, and then we can merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #13723: Fixes #13621
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723#issuecomment-975001443
Hi @penghuazhou
The checkstyle failed. Please take a look. https://github.com/apache/shardingsphere/runs/4281524530?check_suite_focus=true#step:5:3206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #13723: Fixes #13621
Posted by GitBox <gi...@apache.org>.
TeslaCN merged pull request #13723:
URL: https://github.com/apache/shardingsphere/pull/13723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org