You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/22 19:11:44 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization

jerrypeng commented on a change in pull request #3874: [ISSUE 3763] - Implementing Function authorization
URL: https://github.com/apache/pulsar/pull/3874#discussion_r268305285
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
 ##########
 @@ -38,6 +50,13 @@
     private final WorkerService workerService;
     private WorkerServer server;
 
+    private ZooKeeperClientFactory zkClientFactory = null;
 
 Review comment:
   @cckellogg this is worker and not the worker service.  This code is run when the worker and workerservice is running separately than the broker.  Look at the code for WorkerService,  I do pass in both the authentication provider and authorization provider to it. If we are running the function worker with the broker, than the PulsarService will pass those in and if not, this class, Worker will pass those in

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services