You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2016/04/14 17:23:20 UTC
Review Request 46210: Services status check labels and progress bar
changes for Hive, Pig and Files view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46210/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.
Bugs: AMBARI-15886
https://issues.apache.org/jira/browse/AMBARI-15886
Repository: ambari
Description
-------
- add a function for checking if all the serivce checks are completed.
- using this function on UI to show the correct label and progress bar status.
Diffs
-----
contrib/views/files/src/main/resources/ui/app/controllers/splash.js 84a404a
contrib/views/files/src/main/resources/ui/app/routes/splash.js 6005937
contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 72406a0
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js eec1f17
contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 1ff155c
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 3e81a9c
contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 959d6d0
contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5223a5a
contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 7455a4f
Diff: https://reviews.apache.org/r/46210/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 46210: Services status check labels and progress
bar changes for Hive, Pig and Files view
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46210/#review129730
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On April 14, 2016, 3:23 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46210/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 3:23 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.
>
>
> Bugs: AMBARI-15886
> https://issues.apache.org/jira/browse/AMBARI-15886
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add a function for checking if all the serivce checks are completed.
> - using this function on UI to show the correct label and progress bar status.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/controllers/splash.js 84a404a
> contrib/views/files/src/main/resources/ui/app/routes/splash.js 6005937
> contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 72406a0
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js eec1f17
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 1ff155c
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 3e81a9c
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 959d6d0
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5223a5a
> contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 7455a4f
>
> Diff: https://reviews.apache.org/r/46210/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 46210: Services status check labels and progress
bar changes for Hive, Pig and Files view
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
> On April 14, 2016, 7:21 p.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/files/src/main/resources/ui/app/controllers/splash.js, line 98
> > <https://reviews.apache.org/r/46210/diff/1/?file=1344527#file1344527line98>
> >
> > allTestsCompleted property and modelhdfsTestDone are exactly same. What is the requirement of introducing another computed property?
so, as of now there only one check for file browser view but going forward it may have multiple checks similar to hive and ping views. that's when we do not need to change the code on HTML.
- Pallav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46210/#review128958
-----------------------------------------------------------
On April 14, 2016, 3:23 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46210/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 3:23 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.
>
>
> Bugs: AMBARI-15886
> https://issues.apache.org/jira/browse/AMBARI-15886
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add a function for checking if all the serivce checks are completed.
> - using this function on UI to show the correct label and progress bar status.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/controllers/splash.js 84a404a
> contrib/views/files/src/main/resources/ui/app/routes/splash.js 6005937
> contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 72406a0
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js eec1f17
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 1ff155c
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 3e81a9c
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 959d6d0
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5223a5a
> contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 7455a4f
>
> Diff: https://reviews.apache.org/r/46210/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 46210: Services status check labels and progress
bar changes for Hive, Pig and Files view
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46210/#review128958
-----------------------------------------------------------
contrib/views/files/src/main/resources/ui/app/controllers/splash.js (line 98)
<https://reviews.apache.org/r/46210/#comment192412>
allTestsCompleted property and modelhdfsTestDone are exactly same. What is the requirement of introducing another computed property?
- DIPAYAN BHOWMICK
On April 14, 2016, 3:23 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46210/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 3:23 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.
>
>
> Bugs: AMBARI-15886
> https://issues.apache.org/jira/browse/AMBARI-15886
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add a function for checking if all the serivce checks are completed.
> - using this function on UI to show the correct label and progress bar status.
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/app/controllers/splash.js 84a404a
> contrib/views/files/src/main/resources/ui/app/routes/splash.js 6005937
> contrib/views/files/src/main/resources/ui/app/templates/splash.hbs 72406a0
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/splash.js eec1f17
> contrib/views/hive/src/main/resources/ui/hive-web/app/routes/splash.js 1ff155c
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/splash.hbs 3e81a9c
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js 959d6d0
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 5223a5a
> contrib/views/pig/src/main/resources/ui/pig-web/app/templates/splash.hbs 7455a4f
>
> Diff: https://reviews.apache.org/r/46210/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>