You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/03 03:35:04 UTC
[GitHub] [flink] Myasuka commented on a change in pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data
Myasuka commented on a change in pull request #17525:
URL: https://github.com/apache/flink/pull/17525#discussion_r741597480
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBRocksStateKeysAndNamespacesIteratorTest.java
##########
@@ -129,4 +131,74 @@ public void testIterator() throws Exception {
}
}
}
+
+ @Test
+ public void testIteratorUpdateMapStateMultipleTimes() throws Exception {
Review comment:
First of all, this test has many code same as `#testIteratorHelper`. Secondly, I think we should add new test in `StateBackendTestBase` to verify all state-backends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org