[jira] Commented: (IVY-362) StatusManager needs to be rewritten for clarity

["Stephane Bailliez (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/IVY-362?page=comments#action_12461012 ] 
            
Stephane Bailliez commented on IVY-362:
---------------------------------------

Code that needs to be removed as well are things like:

        Boolean isIntegration = (Boolean)_statusIntegrationMap.get(status);
        if (isIntegration == null) {
            Message.debug("unknown status "+status+": assuming integration");
            return true;
        }

It really adds more code than necessary.

The map initialization is done internally and based on a status which provides a boolean...
so unless things went dramatically wrong in the initialization code, it is better to have the code to blow up instantly because there is a mistake in the initialization code rather than silently continuing as assigning values by itself.

> StatusManager needs to be rewritten for clarity
> -----------------------------------------------
>
>                 Key: IVY-362
>                 URL: http://issues.apache.org/jira/browse/IVY-362
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.4.1
>            Reporter: Stephane Bailliez
>            Priority: Minor
>
> StatusManager has comments which are not reflecting the implementation.
> addStatus could be called as well after creating it with the non-bean ctor, it would make it as useless as the map is already precomputed.
> There are subtleties in this class that needs to be eliminated or make more clear.
> It either need to be simplified and/or needs to fail on update methods when the maps have already been precomputed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira