[GitHub] spark pull request #17967: [SPARK-14659][ML] RFormula consistent with R when...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17967#discussion_r116387686
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala ---
    @@ -37,6 +37,29 @@ import org.apache.spark.sql.types._
      */
     private[feature] trait RFormulaBase extends HasFeaturesCol with HasLabelCol {
     
    +  /**
    +   * Param for how to order labels of string column. The first label after ordering is assigned
    +   * an index of 0.
    +   * Options are:
    +   *   - 'frequencyDesc': descending order by label frequency (most frequent label assigned 0)
    +   *   - 'frequencyAsc': ascending order by label frequency (least frequent label assigned 0)
    +   *   - 'alphabetDesc': descending alphabetical order
    +   *   - 'alphabetAsc': ascending alphabetical order
    +   * Default is 'frequencyDesc'.
    +   *
    +   * @group param
    +   */
    +  @Since("2.3.0")
    +  final val stringOrderType: Param[String] = new Param(this, "stringOrderType",
    +    "how to order labels of string column. " +
    --- End diff --
    
    should it be capitalize `"How`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org