You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/02 14:09:54 UTC

[GitHub] [spark] cloud-fan commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted

cloud-fan commented on pull request #34702:
URL: https://github.com/apache/spark/pull/34702#issuecomment-984661306


   The code change LGTM. Since there are quite some TPCDS queries that get plan changes, can we run a TPCDS benchmark to verify performance improvement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org