You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/09/07 21:57:06 UTC

[GitHub] [activemq-artemis] michaelandrepearce commented on a diff in pull request #4200: ARTEMIS-3763 Use margin when checking time difference between broker and database

michaelandrepearce commented on code in PR #4200:
URL: https://github.com/apache/activemq-artemis/pull/4200#discussion_r965334358


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/storage/DatabaseStorageConfiguration.java:
##########
@@ -67,6 +67,8 @@ public class DatabaseStorageConfiguration implements StoreConfiguration {
 
    private long jdbcJournalSyncPeriodMillis = ActiveMQDefaultConfiguration.getDefaultJdbcJournalSyncPeriodMillis();
 
+   private long dataSourceTimeMargin = 250;

Review Comment:
   Constant should be in the activemqdefaultconfiguration 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org