[jira] [Commented] (TEZ-1710) Add support for admin AM/task launch opts

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185999#comment-14185999 ] 

Hitesh Shah commented on TEZ-1710:
----------------------------------

Comments:
  - question is which value overrides the other? As per offline discussions, it seems that the rightmost command line option likely wins. In this, we should put "admin" settings at the rightmost. If we are referring to these as cluster defaults which can be overridden by the user then a diff naming convention should used. 

If we designate this to be cluster defaults, I think we should change our current default values of command opts to cluster defaults and keep the config default for user specified opts to be "". 

For addDefaultsToTaskLaunchCmdOpts(), we have 3 ways to specific opts:
   - programmatic on vertex api
   - user configured opts
   - cluster default opts

What should be the order of priority ( assuming cluster default is always lowest ) ? Also, do we only pick one of the 2 from programmatic vs user config?

Any reason for the change in YARNRunner? i.e. "dagAMConf.set(TezConfiguration.TEZ_AM_LAUNCH_CMD_OPTS, javaOpts.toString());" ? 





> Add support for admin AM/task launch opts
> -----------------------------------------
>
>                 Key: TEZ-1710
>                 URL: https://issues.apache.org/jira/browse/TEZ-1710
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-1710.1.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)