You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by adityasharad <gi...@git.apache.org> on 2017/04/28 22:19:36 UTC
[GitHub] kafka pull request #2939: MINOR: Fix some lgtm.com alerts, ensuring certain ...
GitHub user adityasharad opened a pull request:
https://github.com/apache/kafka/pull/2939
MINOR: Fix some lgtm.com alerts, ensuring certain input/output resources are closed.
This PR uses the try-with-resources construct to ensure that certain input and output resources are always closed, preventing possible memory leaks.
This addresses some of the alerts found on lgtm.com: see the "Close input resource" and "Close output resource" rules at https://lgtm.com/projects/g/apache/kafka/alerts/.
Type arguments have been added in one unrelated place to get one of the modified files to compile.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adityasharad/kafka fix/lgtm-alerts-streams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2939.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2939
----
commit 2b321e60f41bfc482b471a7587281e690621d549
Author: Aditya Sharad <ad...@semmle.com>
Date: 2017-04-28T22:08:01Z
MINOR: Use try-with-resources to ensure certain input streams are closed.
commit 8329649ccf1f3bdd76568f86f223e17953475905
Author: Aditya Sharad <ad...@semmle.com>
Date: 2017-04-28T22:08:46Z
MINOR: Use try-with-resources to ensure certain output resources are closed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---