You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "fangchenli (via GitHub)" <gi...@apache.org> on 2026/01/11 07:50:34 UTC
[PR] [SPARK-54941][Python] Add tests for pa.scalar type coercion [spark]
fangchenli opened a new pull request, #53762:
URL: https://github.com/apache/spark/pull/53762
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add tests for pa.scalar type coercion.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We want to monitor changes in PyArrow's behavior.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Opus 4.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][PYTHON][TESTS] Add tests for pa.scalar type coercion for numerical types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #53762:
URL: https://github.com/apache/spark/pull/53762#discussion_r2710851062
##########
python/pyspark/tests/upstream/pyarrow/test_pyarrow_scalar_type_coercion.py:
##########
@@ -0,0 +1,240 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+Test pa.scalar type coercion behavior when creating scalars with explicit type parameter.
+
+This test monitors the behavior of PyArrow's type coercion to ensure PySpark's assumptions
+about PyArrow behavior remain valid across versions.
+
+Test categories:
+1. Null coercion - None to numeric types
+2. Numeric types - int, float, decimal coercion and boundaries
+
+The helper method pattern is adapted from PR #53721 (pa.array type coercion tests).
+"""
+
+import math
+import unittest
+from decimal import Decimal
+
+from pyspark.testing.utils import (
+ have_pyarrow,
+ pyarrow_requirement_message,
+)
+
+
+@unittest.skipIf(not have_pyarrow, pyarrow_requirement_message)
+class PyArrowScalarTypeCoercionTests(unittest.TestCase):
+ """Test PyArrow's type coercion behavior for pa.scalar with explicit type parameter."""
+
+ # =========================================================================
+ # Helper methods
+ # =========================================================================
+
+ def _run_coercion_tests(self, cases):
+ """Run coercion tests: (value, target_type)."""
+ import pyarrow as pa
+
+ for value, target_type in cases:
+ scalar = pa.scalar(value, type=target_type)
+ self.assertEqual(scalar.type, target_type)
+
+ def _run_coercion_tests_with_values(self, cases):
+ """Run coercion tests with value verification: (value, target_type, expected)."""
+ import pyarrow as pa
+
+ for value, target_type, expected in cases:
+ scalar = pa.scalar(value, type=target_type)
+ self.assertEqual(scalar.type, target_type)
+ self.assertEqual(scalar.as_py(), expected)
+
+ def _run_error_tests(self, cases, error_type):
+ """Run tests expecting errors: (value, target_type)."""
+ import pyarrow as pa
+
+ for value, target_type in cases:
+ with self.assertRaises(error_type):
+ pa.scalar(value, type=target_type)
+
+ # =========================================================================
+ # SECTION 1: Null Coercion
+ # =========================================================================
+
+ def test_null_coercion(self):
+ """Test that None can be coerced to numeric types as a null scalar."""
+ import pyarrow as pa
+
+ target_types = [
+ pa.int8(),
+ pa.int16(),
+ pa.int32(),
+ pa.int64(),
+ pa.uint8(),
+ pa.uint16(),
+ pa.uint32(),
+ pa.uint64(),
+ pa.float32(),
+ pa.float64(),
+ pa.decimal128(20, 2),
Review Comment:
we can add it in followups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][PYTHON][TESTS] Add tests for pa.scalar type coercion for numerical types [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #53762:
URL: https://github.com/apache/spark/pull/53762#discussion_r2710556183
##########
python/pyspark/tests/upstream/pyarrow/test_pyarrow_scalar_type_coercion.py:
##########
@@ -0,0 +1,240 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+Test pa.scalar type coercion behavior when creating scalars with explicit type parameter.
+
+This test monitors the behavior of PyArrow's type coercion to ensure PySpark's assumptions
+about PyArrow behavior remain valid across versions.
+
+Test categories:
+1. Null coercion - None to numeric types
+2. Numeric types - int, float, decimal coercion and boundaries
+
+The helper method pattern is adapted from PR #53721 (pa.array type coercion tests).
+"""
+
+import math
+import unittest
+from decimal import Decimal
+
+from pyspark.testing.utils import (
+ have_pyarrow,
+ pyarrow_requirement_message,
+)
+
+
+@unittest.skipIf(not have_pyarrow, pyarrow_requirement_message)
+class PyArrowScalarTypeCoercionTests(unittest.TestCase):
+ """Test PyArrow's type coercion behavior for pa.scalar with explicit type parameter."""
+
+ # =========================================================================
+ # Helper methods
+ # =========================================================================
+
+ def _run_coercion_tests(self, cases):
+ """Run coercion tests: (value, target_type)."""
+ import pyarrow as pa
+
+ for value, target_type in cases:
+ scalar = pa.scalar(value, type=target_type)
+ self.assertEqual(scalar.type, target_type)
+
+ def _run_coercion_tests_with_values(self, cases):
+ """Run coercion tests with value verification: (value, target_type, expected)."""
+ import pyarrow as pa
+
+ for value, target_type, expected in cases:
+ scalar = pa.scalar(value, type=target_type)
+ self.assertEqual(scalar.type, target_type)
+ self.assertEqual(scalar.as_py(), expected)
+
+ def _run_error_tests(self, cases, error_type):
+ """Run tests expecting errors: (value, target_type)."""
+ import pyarrow as pa
+
+ for value, target_type in cases:
+ with self.assertRaises(error_type):
+ pa.scalar(value, type=target_type)
+
+ # =========================================================================
+ # SECTION 1: Null Coercion
+ # =========================================================================
+
+ def test_null_coercion(self):
+ """Test that None can be coerced to numeric types as a null scalar."""
+ import pyarrow as pa
+
+ target_types = [
+ pa.int8(),
+ pa.int16(),
+ pa.int32(),
+ pa.int64(),
+ pa.uint8(),
+ pa.uint16(),
+ pa.uint32(),
+ pa.uint64(),
+ pa.float32(),
+ pa.float64(),
+ pa.decimal128(20, 2),
Review Comment:
should we also test `pa.decimal256(76, 10)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][Python] Add tests for pa.scalar type coercion [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53762:
URL: https://github.com/apache/spark/pull/53762#issuecomment-3734201112
## JIRA Issue Information
=== Sub-task SPARK-54941 ===
Summary: Add tests for pa.scalar type coercion
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][PYTHON][TESTS] Add tests for pa.scalar type coercion for numerical types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #53762: [SPARK-54941][PYTHON][TESTS] Add tests for pa.scalar type coercion for numerical types
URL: https://github.com/apache/spark/pull/53762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][PYTHON][TESTS] Add tests for pa.scalar type coercion for numerical types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53762:
URL: https://github.com/apache/spark/pull/53762#issuecomment-3776072625
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54941][Python] Add tests for pa.scalar type coercion [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #53762:
URL: https://github.com/apache/spark/pull/53762#discussion_r2684467971
##########
python/pyspark/tests/upstream/pyarrow/test_pyarrow_scalar_type_coercion.py:
##########
@@ -0,0 +1,458 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+Tests for PyArrow pa.scalar type coercion behavior.
+
+This module tests how PyArrow coerces values when an explicit type is provided
+to pa.scalar(value, type=target_type). This helps ensure PySpark's assumptions
+about PyArrow behavior remain valid across versions.
+"""
+
+import datetime
+import unittest
+from decimal import Decimal
+from zoneinfo import ZoneInfo
+
+from pyspark.testing.utils import (
+ have_numpy,
+ have_pandas,
+ have_pyarrow,
+ numpy_requirement_message,
+ pandas_requirement_message,
+ pyarrow_requirement_message,
+)
+
+
+@unittest.skipIf(not have_pyarrow, pyarrow_requirement_message)
+class PyArrowScalarTypeCoercionTests(unittest.TestCase):
+ """Test pa.scalar type coercion with explicit type parameter."""
+
+ def test_integer_narrowing(self):
Review Comment:
It seems some cases are not tested, even though they might be invalid right now, e.g.
```
pa.scalar("2024-01-15", pa.date32())
pa.scalar(datetime.date(2026, 1, 13), pa.string())
pa.scalar(float("nan"), pa.decimal128(20, 2))
```
shall we use a nested loop to cover all cases?
```
for value in [None, 1, 1.5, ...]:
for pa_type in [...]:
try:
s = pa.scalar(value, pa_type)
self.assertEqual(s.type, pa.type)
self.assertEqual(s.as_py(), value)
exception:
check error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org