[GitHub] [airflow] potiuk commented on pull request #29143: Demonstrate usage of the PythonSensor

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1412956934

   Oh yes - I absolutely agree example dags should not be loaded by default.This is even one of the reasons why in Breeze it is disabled by default. And if anything I  would argue for changing the flag to False. Since this is not a production setting, I think we could flip it to False without breaking any "backwards compatibility promise". 
   
   Maybe that is a better approach - keep the examples where they are but disable them. Or maybe even we could fine-grain it and enable/disable different types of the examples. That sounds like a better idea that introducing a new place where example dags are stored without the "easiness" of running them.
   
   I think you might not understood why I think it's good to have the code in example_dags and copied from there - it's not because it is a python file, but it is because I can easily run airflow wiith a flag  and run them without even copy-pasting the code. This is for example how I as a maintainer test a new release of airflow. I run `breeze start-airflow --use-airflow-version 2.5.1rc1 --load-example-dags --load-default-connections` and then I run many of those examples - and by seing them succeed, I can be reasonably sure that our example docs are also "fine". 
   
   But yes - keeping the flag disabled by default is a very good idea (like it is in breeze). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org