[GitHub] spark pull request #19369: [SPARK-22147][CORE] Removed redundant allocations...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19369#discussion_r142328284
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockReplicationPolicy.scala ---
    @@ -85,11 +65,9 @@ object BlockReplicationUtils {
        *         randomly shuffle elems
        */
       def getRandomSample[T](elems: Seq[T], m: Int, r: Random): List[T] = {
    -    if (elems.size > m) {
    -      getSampleIds(elems.size, m, r).map(elems(_))
    -    } else {
    -      r.shuffle(elems).toList
    -    }
    +    // This takes linear space, but is stable wrt m. That is for a fixed
    --- End diff --
    
    @superbobry what do you think about just removing the test?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org