You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Ted Dunning (JIRA)" <ji...@apache.org> on 2010/11/15 16:32:14 UTC

[jira] Created: (MAHOUT-545) GSON not a good fit for deserializing SGD models

GSON not a good fit for deserializing SGD models
------------------------------------------------

                 Key: MAHOUT-545
                 URL: https://issues.apache.org/jira/browse/MAHOUT-545
             Project: Mahout
          Issue Type: Bug
          Components: Classification
    Affects Versions: 0.4
            Reporter: Ted Dunning
             Fix For: 0.5


The problem is that GSON uses JavaCC which does LL(k) parsing.  The way that the JSON grammar is expressed causes stack recursion for each element of
a vector.

This is evil for parsing large models.

I will be changing ModelSerializer to fix this and will provide a reverse compatible mode for anybody who has been able to serialize/deserialize these models in the past.  My thought is to just make all the SGD models Writables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAHOUT-545) GSON not a good fit for deserializing SGD models

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975962#action_12975962 ] 

Hudson commented on MAHOUT-545:
-------------------------------

Integrated in Mahout-Quality #528 (See [https://hudson.apache.org/hudson/job/Mahout-Quality/528/])
    MAHOUT-545 - Big patch to support writable classifiers.


> GSON not a good fit for deserializing SGD models
> ------------------------------------------------
>
>                 Key: MAHOUT-545
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-545
>             Project: Mahout
>          Issue Type: Bug
>          Components: Classification
>    Affects Versions: 0.4
>            Reporter: Ted Dunning
>             Fix For: 0.5
>
>
> The problem is that GSON uses JavaCC which does LL(k) parsing.  The way that the JSON grammar is expressed causes stack recursion for each element of
> a vector.
> This is evil for parsing large models.
> I will be changing ModelSerializer to fix this and will provide a reverse compatible mode for anybody who has been able to serialize/deserialize these models in the past.  My thought is to just make all the SGD models Writables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MAHOUT-545) GSON not a good fit for deserializing SGD models

Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Dunning resolved MAHOUT-545.
--------------------------------

    Resolution: Fixed

Committed.

> GSON not a good fit for deserializing SGD models
> ------------------------------------------------
>
>                 Key: MAHOUT-545
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-545
>             Project: Mahout
>          Issue Type: Bug
>          Components: Classification
>    Affects Versions: 0.4
>            Reporter: Ted Dunning
>             Fix For: 0.5
>
>
> The problem is that GSON uses JavaCC which does LL(k) parsing.  The way that the JSON grammar is expressed causes stack recursion for each element of
> a vector.
> This is evil for parsing large models.
> I will be changing ModelSerializer to fix this and will provide a reverse compatible mode for anybody who has been able to serialize/deserialize these models in the past.  My thought is to just make all the SGD models Writables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.