You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/23 20:22:54 UTC

[GitHub] [airflow] dimon222 commented on a change in pull request #19789: Fix missing region_name arguments in AWS provider

dimon222 commented on a change in pull request #19789:
URL: https://github.com/apache/airflow/pull/19789#discussion_r755476557



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -539,7 +539,7 @@ def expand_role(self, role: str) -> str:
         if "/" in role:
             return role
         else:
-            session, endpoint_url = self._get_credentials()
+            session, endpoint_url = self._get_credentials(region_name=None)

Review comment:
       Since `_get_credentials` itself described region_name via hint as `Optional[Str]`... Should we instead add default = None for it in arguments?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org