You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by jf...@apache.org on 2006/07/29 01:54:21 UTC
svn commit: r426711 - in /apr/apr-util/trunk: include/apr_uri.h uri/apr_uri.c
Author: jfclere
Date: Fri Jul 28 16:54:20 2006
New Revision: 426711
URL: http://svn.apache.org/viewvc?rev=426711&view=rev
Log:
Add AJP for Tomcat for example.
Modified:
apr/apr-util/trunk/include/apr_uri.h
apr/apr-util/trunk/uri/apr_uri.c
Modified: apr/apr-util/trunk/include/apr_uri.h
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/include/apr_uri.h?rev=426711&r1=426710&r2=426711&view=diff
==============================================================================
--- apr/apr-util/trunk/include/apr_uri.h (original)
+++ apr/apr-util/trunk/include/apr_uri.h Fri Jul 28 16:54:20 2006
@@ -58,6 +58,7 @@
#define APR_URI_NFS_DEFAULT_PORT 2049 /**< default NFS port */
#define APR_URI_TIP_DEFAULT_PORT 3372 /**< default TIP port */
#define APR_URI_SIP_DEFAULT_PORT 5060 /**< default SIP port */
+#define APR_URI_AJP_DEFAULT_PORT 8009 /**< default AJP port */
/** Flags passed to unparse_uri_components(): */
/** suppress "scheme://user\@site:port" */
Modified: apr/apr-util/trunk/uri/apr_uri.c
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/uri/apr_uri.c?rev=426711&r1=426710&r2=426711&view=diff
==============================================================================
--- apr/apr-util/trunk/uri/apr_uri.c (original)
+++ apr/apr-util/trunk/uri/apr_uri.c Fri Jul 28 16:54:20 2006
@@ -67,6 +67,7 @@
{"acap", APR_URI_ACAP_DEFAULT_PORT},
{"telnet", APR_URI_TELNET_DEFAULT_PORT},
{"ssh", APR_URI_SSH_DEFAULT_PORT},
+ {"ajp", APR_URI_AJP_DEFAULT_PORT},
{ NULL, 0xFFFF } /* unknown port */
};
Re: svn commit: r426711 - in /apr/apr-util/trunk: include/apr_uri.h uri/apr_uri.c
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 7/29/06, Colm MacCarthaigh <co...@stdlib.net> wrote:
> On Fri, Jul 28, 2006 at 10:04:30PM -0700, Garrett Rooney wrote:
> > Personally, I'm -1 on us adding support for any non-registered port
> > types in APR-Util's URL parser.
>
> Same here.
Ditto. -- justin
Re: svn commit: r426711 - in /apr/apr-util/trunk: include/apr_uri.h uri/apr_uri.c
Posted by Colm MacCarthaigh <co...@stdlib.net>.
On Fri, Jul 28, 2006 at 10:04:30PM -0700, Garrett Rooney wrote:
> Personally, I'm -1 on us adding support for any non-registered port
> types in APR-Util's URL parser.
Same here.
> Perhaps someone in the Tomcat community can get in touch with the IANA
> and do the appropriate begging and pleading for this port to be
> assigned to them, despite the fact that they clearly failed to follow
> the rules when adopting it in the first place.
I doubt very very much that AJP would gain an IANA-assigned port, as the
protocol is generally not used on the public internet, nor are there
widespread independent implementations. I went through the process for
SpamAssassin about four years ago (I picked the port it runs on), and
got nowhere :-)
--
Colm MacCárthaigh Public Key: colm+pgp@stdlib.net
Re: svn commit: r426711 - in /apr/apr-util/trunk: include/apr_uri.h
uri/apr_uri.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 07/29/2006 07:04 AM, Garrett Rooney wrote:
> Personally, I'm -1 on us adding support for any non-registered port
> types in APR-Util's URL parser. Perhaps someone in the Tomcat
> community can get in touch with the IANA and do the appropriate
> begging and pleading for this port to be assigned to them, despite the
> fact that they clearly failed to follow the rules when adopting it in
> the first place.
There is also a comment in http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/ajp.h
that 8009 is a port used by the OS on Netware.
Regards
Rüdiger
Re: svn commit: r426711 - in /apr/apr-util/trunk: include/apr_uri.h uri/apr_uri.c
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 7/28/06, jfclere@apache.org <jf...@apache.org> wrote:
> Author: jfclere
> Date: Fri Jul 28 16:54:20 2006
> New Revision: 426711
>
> URL: http://svn.apache.org/viewvc?rev=426711&view=rev
> Log:
> Add AJP for Tomcat for example.
>
> Modified:
> apr/apr-util/trunk/include/apr_uri.h
> apr/apr-util/trunk/uri/apr_uri.c
>
> Modified: apr/apr-util/trunk/include/apr_uri.h
> URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/include/apr_uri.h?rev=426711&r1=426710&r2=426711&view=diff
> ==============================================================================
> --- apr/apr-util/trunk/include/apr_uri.h (original)
> +++ apr/apr-util/trunk/include/apr_uri.h Fri Jul 28 16:54:20 2006
> @@ -58,6 +58,7 @@
> #define APR_URI_NFS_DEFAULT_PORT 2049 /**< default NFS port */
> #define APR_URI_TIP_DEFAULT_PORT 3372 /**< default TIP port */
> #define APR_URI_SIP_DEFAULT_PORT 5060 /**< default SIP port */
> +#define APR_URI_AJP_DEFAULT_PORT 8009 /**< default AJP port */
You know, I didn't actually know this until I saw this commit, but it
turns out that port 8009 isn't actually officially assigned to anyone,
AJP appears to have started using it without asking the IANA for
permission first.
For what it's worth, it appears that one can attempt to request a new
port assignment at the following url:
http://www.iana.org/cgi-bin/usr-port-number.pl
Personally, I'm -1 on us adding support for any non-registered port
types in APR-Util's URL parser. Perhaps someone in the Tomcat
community can get in touch with the IANA and do the appropriate
begging and pleading for this port to be assigned to them, despite the
fact that they clearly failed to follow the rules when adopting it in
the first place.
=garrett