You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/06 17:22:46 UTC

[GitHub] [arrow] rok commented on pull request #10176: ARROW-11759: [C++] Kernel to extract datetime components (year, month, day, etc) from timestamp type

rok commented on pull request #10176:
URL: https://github.com/apache/arrow/pull/10176#issuecomment-833702932


   It seems tests on windows are not able to download IANA timezone database or access it post-download (https://howardhinnant.github.io/date/tz.html#Installation). I'll solve it but meanwhile I I'd like to ask for review.
   
   Open questions I have at the moment:
   - Is it possible to match kernels to zoned timestamps when registering or do we have to keep matching at runtime [like so](https://github.com/apache/arrow/blob/2765cefc737ac8b5c364a20f8ff94fc158b91b37/cpp/src/arrow/compute/kernels/scalar_temporal.cc#L58).
   - What would be a good array type for isodate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org