You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/10 07:49:00 UTC

[GitHub] [flink] GOODBOY008 opened a new pull request, #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

GOODBOY008 opened a new pull request, #21481:
URL: https://github.com/apache/flink/pull/21481

   Link https://issues.apache.org/jira/browse/FLINK-30357.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GOODBOY008 commented on pull request #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
GOODBOY008 commented on PR #21481:
URL: https://github.com/apache/flink/pull/21481#issuecomment-1345177869

   @leonardBang Please code review. If you are available. Also I had open a [pr](https://github.com/apache/flink/pull/21482) for branch `release-1.16`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21481:
URL: https://github.com/apache/flink/pull/21481#issuecomment-1345177058

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c6f6b718c01e4b1bb12c61f01e6efb9a250bd10f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6f6b718c01e4b1bb12c61f01e6efb9a250bd10f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6f6b718c01e4b1bb12c61f01e6efb9a250bd10f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GOODBOY008 commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
GOODBOY008 commented on code in PR #21481:
URL: https://github.com/apache/flink/pull/21481#discussion_r1053433401


##########
docs/content.zh/docs/connectors/table/jdbc.md:
##########
@@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言（dialect）的数据库，如 MySQL、O
       <td></td>
       <td><code>DECIMAL(20, 0)</code></td>
     </tr>
-    <tr>
-      <td><code>BIGINT</code></td>
-      <td></td>
-      <td><code>BIGINT</code></td>
-      <td><code>BIGINT</code></td>
-    </tr>

Review Comment:
   I think it's dumplicated.
   ![1671549417933](https://user-images.githubusercontent.com/13617900/208701065-d066c08e-9a42-4b9d-96ef-34174e791102.png)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21481:
URL: https://github.com/apache/flink/pull/21481#discussion_r1053436057


##########
docs/content.zh/docs/connectors/table/jdbc.md:
##########
@@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言（dialect）的数据库，如 MySQL、O
       <td></td>
       <td><code>DECIMAL(20, 0)</code></td>
     </tr>
-    <tr>
-      <td><code>BIGINT</code></td>
-      <td></td>
-      <td><code>BIGINT</code></td>
-      <td><code>BIGINT</code></td>
-    </tr>

Review Comment:
   I don't think it's duplicated, because there's a BIGINT INT UNSIGNED / BIGINT UNSIGNED data type for MySQL (which are the first two lines), but there's also a regular `BIGINT` data type which exists for Postgres. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21481:
URL: https://github.com/apache/flink/pull/21481#discussion_r1053279928


##########
docs/content.zh/docs/connectors/table/jdbc.md:
##########
@@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言（dialect）的数据库，如 MySQL、O
       <td></td>
       <td><code>DECIMAL(20, 0)</code></td>
     </tr>
-    <tr>
-      <td><code>BIGINT</code></td>
-      <td></td>
-      <td><code>BIGINT</code></td>
-      <td><code>BIGINT</code></td>
-    </tr>

Review Comment:
   Why is this removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] GOODBOY008 commented on a diff in pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
GOODBOY008 commented on code in PR #21481:
URL: https://github.com/apache/flink/pull/21481#discussion_r1053441739


##########
docs/content.zh/docs/connectors/table/jdbc.md:
##########
@@ -672,12 +672,6 @@ Flink 支持连接到多个使用方言（dialect）的数据库，如 MySQL、O
       <td></td>
       <td><code>DECIMAL(20, 0)</code></td>
     </tr>
-    <tr>
-      <td><code>BIGINT</code></td>
-      <td></td>
-      <td><code>BIGINT</code></td>
-      <td><code>BIGINT</code></td>
-    </tr>

Review Comment:
   I get it,Thanks for your patient reply.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #21481: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21481:
URL: https://github.com/apache/flink/pull/21481


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org