You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Yagumo Pei (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 15:46:58 UTC
[jira] [Created] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
<s:url> tag can not generate proper namespace when don't assign namespace value in tag.
---------------------------------------------------------------------------------------
Key: WW-3769
URL: https://issues.apache.org/jira/browse/WW-3769
Project: Struts 2
Issue Type: Bug
Components: Plugin - Portlet
Affects Versions: 2.3.1.2
Reporter: Yagumo Pei
I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
public void renderUrl(Writer writer, UrlProvider urlComponent) {
...
urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
...
}
This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223296#comment-13223296 ]
Lukasz Lenart commented on WW-3769:
-----------------------------------
Why do you use PortletUrlRenderer ? Is it a portlet app ?
> <s:url> tag can not generate proper namespace when don't assign namespace value in tag.
> ---------------------------------------------------------------------------------------
>
> Key: WW-3769
> URL: https://issues.apache.org/jira/browse/WW-3769
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Portlet
> Affects Versions: 2.3.1.2
> Reporter: Yagumo Pei
> Fix For: 2.3.2
>
>
> I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
> I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
> {code}
> public void renderUrl(Writer writer, UrlProvider urlComponent) {
> ...
> urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
> ...
> }
> {code}
> This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
Posted by "Lukasz Lenart (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart closed WW-3769.
-----------------------------
Resolution: Fixed
Assignee: Lukasz Lenart
Solved, thanks for reporting!
> <s:url> tag can not generate proper namespace when don't assign namespace value in tag.
> ---------------------------------------------------------------------------------------
>
> Key: WW-3769
> URL: https://issues.apache.org/jira/browse/WW-3769
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Portlet
> Affects Versions: 2.3.1.2
> Reporter: Yagumo Pei
> Assignee: Lukasz Lenart
> Fix For: 2.3.2
>
>
> I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
> I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
> {code}
> public void renderUrl(Writer writer, UrlProvider urlComponent) {
> ...
> urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
> ...
> }
> {code}
> This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
Posted by "Lukasz Lenart (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukasz Lenart updated WW-3769:
------------------------------
Description:
I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
{code}
public void renderUrl(Writer writer, UrlProvider urlComponent) {
...
urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
...
}
{code}
This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
was:
I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
public void renderUrl(Writer writer, UrlProvider urlComponent) {
...
urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
...
}
This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
Fix Version/s: 2.3.2
> <s:url> tag can not generate proper namespace when don't assign namespace value in tag.
> ---------------------------------------------------------------------------------------
>
> Key: WW-3769
> URL: https://issues.apache.org/jira/browse/WW-3769
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Portlet
> Affects Versions: 2.3.1.2
> Reporter: Yagumo Pei
> Fix For: 2.3.2
>
>
> I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
> I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
> {code}
> public void renderUrl(Writer writer, UrlProvider urlComponent) {
> ...
> urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
> ...
> }
> {code}
> This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
Posted by "Yagumo Pei (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223316#comment-13223316 ]
Yagumo Pei commented on WW-3769:
--------------------------------
Yes, I use portlet 1.0.
> <s:url> tag can not generate proper namespace when don't assign namespace value in tag.
> ---------------------------------------------------------------------------------------
>
> Key: WW-3769
> URL: https://issues.apache.org/jira/browse/WW-3769
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Portlet
> Affects Versions: 2.3.1.2
> Reporter: Yagumo Pei
> Fix For: 2.3.2
>
>
> I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
> I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
> {code}
> public void renderUrl(Writer writer, UrlProvider urlComponent) {
> ...
> urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
> ...
> }
> {code}
> This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3769) tag can not generate proper
namespace when don't assign namespace value in tag.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224468#comment-13224468 ]
Hudson commented on WW-3769:
----------------------------
Integrated in Struts2 #428 (See [https://builds.apache.org/job/Struts2/428/])
WW-3769 adds missing line of code to generate namespace without explicit specifying it (Revision 1297994)
Result = SUCCESS
lukaszlenart :
Files :
* /struts/struts2/trunk/plugins/portlet/src/main/java/org/apache/struts2/components/PortletUrlRenderer.java
* /struts/struts2/trunk/plugins/portlet/src/test/java/org/apache/struts2/components
* /struts/struts2/trunk/plugins/portlet/src/test/java/org/apache/struts2/components/PortletAction.java
* /struts/struts2/trunk/plugins/portlet/src/test/java/org/apache/struts2/components/PortletUrlRendererTest.java
* /struts/struts2/trunk/plugins/portlet/src/test/java/org/apache/struts2/views/jsp/PortletUrlTagTest.java
* /struts/struts2/trunk/plugins/portlet/src/test/resources
* /struts/struts2/trunk/plugins/portlet/src/test/resources/struts.xml
> <s:url> tag can not generate proper namespace when don't assign namespace value in tag.
> ---------------------------------------------------------------------------------------
>
> Key: WW-3769
> URL: https://issues.apache.org/jira/browse/WW-3769
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Portlet
> Affects Versions: 2.3.1.2
> Reporter: Yagumo Pei
> Assignee: Lukasz Lenart
> Fix For: 2.3.2
>
>
> I upgrade my application from 2.1.8 to 2.3.1.2, then find that <s:url> can't geneate proper result when I don't assign namespace value in the <s:url> tag. e.g, <s:url value="aaaa/">, in the old version, I got "http://xxx/xxxx&struts.portlet.action=/somenamespace/aaaa", but in the new version, I got "http://xxx/xxxx&struts.portlet.action=/aaaa", the namespace is missing.
> I check source code between 2.1.8 and 2.3.1.2, and find in org.apache.struts2.components.PortletUrlRenderer
> {code}
> public void renderUrl(Writer writer, UrlProvider urlComponent) {
> ...
> urlComponent.setNamespace(urlComponent.determineNamespace(urlComponent.getNamespace(), urlComponent.getStack(),urlComponent.getHttpServletRequest())); // Line 78, in 2.1.8
> ...
> }
> {code}
> This statement is missing in 2.3.1.2, which cause struts can't find namespace by action name. I think it's losing feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira