You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2012/11/07 18:13:11 UTC

[jira] [Created] (CASSANDRA-4928) CQL3 SelectStatement should not share slice query filters amongst ReadCommand

Sylvain Lebresne created CASSANDRA-4928:
-------------------------------------------

             Summary: CQL3 SelectStatement should not share slice query filters amongst ReadCommand
                 Key: CASSANDRA-4928
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4928
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 1.2.0 beta 1
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
             Fix For: 1.2.0 rc1
         Attachments: 4928.txt

In 1.2, SliceQueryFilter is stateful and should thus not be shared but SelectStatement is doing some sharing in the case of an IN query. This is the reason why cql_test:TestCQL.limit_multiget_test in the dtests is failing intermittently.

Let's be clear that the fact that SliceQueryFilter is stateful is ugly, but that is a concession made for performance until we can refactor all this more cleanly (which still being efficient). Such refactor being, as far as I can tell, far from trivial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4928) CQL3 SelectStatement should not share slice query filters amongst ReadCommand

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492544#comment-13492544 ] 

Jonathan Ellis commented on CASSANDRA-4928:
-------------------------------------------

+1
                
> CQL3 SelectStatement should not share slice query filters amongst ReadCommand
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4928
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4928
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 1.2.0 rc1
>
>         Attachments: 4928.txt
>
>
> In 1.2, SliceQueryFilter is stateful and should thus not be shared but SelectStatement is doing some sharing in the case of an IN query. This is the reason why cql_test:TestCQL.limit_multiget_test in the dtests is failing intermittently.
> Let's be clear that the fact that SliceQueryFilter is stateful is ugly, but that is a concession made for performance until we can refactor all this more cleanly (which still being efficient). Such refactor being, as far as I can tell, far from trivial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4928) CQL3 SelectStatement should not share slice query filters amongst ReadCommand

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-4928:
----------------------------------------

    Attachment: 4928.txt
    
> CQL3 SelectStatement should not share slice query filters amongst ReadCommand
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4928
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4928
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 1.2.0 rc1
>
>         Attachments: 4928.txt
>
>
> In 1.2, SliceQueryFilter is stateful and should thus not be shared but SelectStatement is doing some sharing in the case of an IN query. This is the reason why cql_test:TestCQL.limit_multiget_test in the dtests is failing intermittently.
> Let's be clear that the fact that SliceQueryFilter is stateful is ugly, but that is a concession made for performance until we can refactor all this more cleanly (which still being efficient). Such refactor being, as far as I can tell, far from trivial.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira