You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Scott Gray <sc...@hotwaxmedia.com> on 2009/10/21 11:56:23 UTC
Re: svn commit: r827921 - /ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl
Hi Hans,
Please try and keep in mind that inline styling == bad practice.
Thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
On 21/10/2009, at 9:39 PM, hansbak@apache.org wrote:
> Author: hansbak
> Date: Wed Oct 21 08:39:24 2009
> New Revision: 827921
>
> URL: http://svn.apache.org/viewvc?rev=827921&view=rev
> Log:
> improve displa of customer request in project manager
>
> Modified:
> ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl
>
> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
> request/overViewRequestItems.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827921&r1=827920&r2=827921&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl (original)
> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl Wed Oct 21 08:39:24 2009
> @@ -53,45 +53,51 @@
> <textarea readonly="readonly" rows="15" cols="72">$
> {custRequestItemList.story}</textarea>
> </#if>
> </td>
> - <td>
> +
> + <#-- now show notes details per line item -->
> + <td colspan="1" align="right" valign="top" width="50%"
> nowrap="nowrap" style="background-color:white; vertical-align: top;">
> + <#if custRequestItemNoteViews?has_content>
> + <table class="basic-table hover-bar"
> cellspacing="0">
> + <tr class="header-row">
> + <td>
> + </td>
> + <td>
> + ${uiLabelMap.CommonNbr}
> + </td>
> + <td>
> + ${uiLabelMap.CommonNote}
> + </td>
> + <td>
> + ${uiLabelMap.CommonDate}
> + </td>
> + </tr>
> + <#list custRequestItemNoteViews as
> custRequestItemNoteViewList>
> + <#if
> custRequestItemNoteViewList.custRequestItemSeqId ==
> custRequestItemList.custRequestItemSeqId>
> + <#if row?has_content>
> + <#assign row="">
> + <#else>
> + <#assign row="alternate-row">
> + </#if>
> + <tr class="${row}">
> + <td>
> + </td>
> + <td>
> + $
> {custRequestItemNoteViewList.noteId}
> + </td>
> + <td >
> + $
> {custRequestItemNoteViewList.noteInfo}
> + </td>
> + <td>
> + $
> {custRequestItemNoteViewList.noteDateTime.toString().substring(0,10)}
> + </td>
> + </tr>
> + </#if>
> + </#list>
> + </table>
> + </#if>
> <a href="<@ofbizUrl>requestitemnotes?custRequestId=$
> {custRequestItemList.custRequestId}&custRequestItemSeqId=$
> {custRequestItemList.custRequestItemSeqId}</...@ofbizUrl>"
> class="linktext">${uiLabelMap.OrderAddNote}</a>
> </td>
> </tr>
> - <tr class="header-row">
> - <td>
> - </td>
> - <td>
> - ${uiLabelMap.CommonNbr}
> - </td>
> - <td>
> - ${uiLabelMap.CommonNote}
> - </td>
> - <td>
> - ${uiLabelMap.CommonDate}
> - </td>
> - </tr>
> - <#list custRequestItemNoteViews as
> custRequestItemNoteViewList>
> - <#if custRequestItemNoteViewList.custRequestItemSeqId
> == custRequestItemList.custRequestItemSeqId>
> - <#if row?has_content>
> - <#assign row="">
> - <#else>
> - <#assign row="alternate-row">
> - </#if>
> - <tr class="${row}">
> - <td>
> - </td>
> - <td>
> - ${custRequestItemNoteViewList.noteId}
> - </td>
> - <td >
> - ${custRequestItemNoteViewList.noteInfo}
> - </td>
> - <td>
> - $
> {custRequestItemNoteViewList.noteDateTime.toString().substring(0,10)}
> - </td>
> - </tr>
> - </#if>
> - </#list>
> </#if>
> </#list>
> </table>
>
>
Re: svn commit: r827921 - /ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
It's not just a bad practice - it makes more work for everyone. Hans,
please revert it until you can use the tools that the rest of us are
so that we don't have to go back and fix it in order to make it more
flexible and useful for the rest of the community. This practice went
out about 6 years ago from even being something that anyone does any
more ....
Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Oct 21, 2009, at 3:56 AM, Scott Gray wrote:
> Hi Hans,
>
> Please try and keep in mind that inline styling == bad practice.
>
> Thanks
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 21/10/2009, at 9:39 PM, hansbak@apache.org wrote:
>
>> Author: hansbak
>> Date: Wed Oct 21 08:39:24 2009
>> New Revision: 827921
>>
>> URL: http://svn.apache.org/viewvc?rev=827921&view=rev
>> Log:
>> improve displa of customer request in project manager
>>
>> Modified:
>> ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl
>>
>> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
>> request/overViewRequestItems.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827921&r1=827920&r2=827921&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl (original)
>> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl Wed Oct 21 08:39:24 2009
>> @@ -53,45 +53,51 @@
>> <textarea readonly="readonly" rows="15" cols="72">$
>> {custRequestItemList.story}</textarea>
>> </#if>
>> </td>
>> - <td>
>> +
>> + <#-- now show notes details per line item -->
>> + <td colspan="1" align="right" valign="top" width="50%"
>> nowrap="nowrap" style="background-color:white; vertical-align: top;">
>> + <#if custRequestItemNoteViews?has_content>
>> + <table class="basic-table hover-bar"
>> cellspacing="0">
>> + <tr class="header-row">
>> + <td>
>> + </td>
>> + <td>
>> + ${uiLabelMap.CommonNbr}
>> + </td>
>> + <td>
>> + ${uiLabelMap.CommonNote}
>> + </td>
>> + <td>
>> + ${uiLabelMap.CommonDate}
>> + </td>
>> + </tr>
>> + <#list custRequestItemNoteViews as
>> custRequestItemNoteViewList>
>> + <#if
>> custRequestItemNoteViewList.custRequestItemSeqId ==
>> custRequestItemList.custRequestItemSeqId>
>> + <#if row?has_content>
>> + <#assign row="">
>> + <#else>
>> + <#assign row="alternate-row">
>> + </#if>
>> + <tr class="${row}">
>> + <td>
>> + </td>
>> + <td>
>> + $
>> {custRequestItemNoteViewList.noteId}
>> + </td>
>> + <td >
>> + $
>> {custRequestItemNoteViewList.noteInfo}
>> + </td>
>> + <td>
>> + $
>> {custRequestItemNoteViewList.noteDateTime.toString().substring(0,10)}
>> + </td>
>> + </tr>
>> + </#if>
>> + </#list>
>> + </table>
>> + </#if>
>> <a href="<@ofbizUrl>requestitemnotes?custRequestId=$
>> {custRequestItemList.custRequestId}&custRequestItemSeqId=$
>> {custRequestItemList.custRequestItemSeqId}</...@ofbizUrl>"
>> class="linktext">${uiLabelMap.OrderAddNote}</a>
>> </td>
>> </tr>
>> - <tr class="header-row">
>> - <td>
>> - </td>
>> - <td>
>> - ${uiLabelMap.CommonNbr}
>> - </td>
>> - <td>
>> - ${uiLabelMap.CommonNote}
>> - </td>
>> - <td>
>> - ${uiLabelMap.CommonDate}
>> - </td>
>> - </tr>
>> - <#list custRequestItemNoteViews as
>> custRequestItemNoteViewList>
>> - <#if custRequestItemNoteViewList.custRequestItemSeqId
>> == custRequestItemList.custRequestItemSeqId>
>> - <#if row?has_content>
>> - <#assign row="">
>> - <#else>
>> - <#assign row="alternate-row">
>> - </#if>
>> - <tr class="${row}">
>> - <td>
>> - </td>
>> - <td>
>> - ${custRequestItemNoteViewList.noteId}
>> - </td>
>> - <td >
>> - ${custRequestItemNoteViewList.noteInfo}
>> - </td>
>> - <td>
>> - $
>> {custRequestItemNoteViewList.noteDateTime.toString().substring(0,10)}
>> - </td>
>> - </tr>
>> - </#if>
>> - </#list>
>> </#if>
>> </#list>
>> </table>
>>
>>
>