[GitHub] [pulsar] eolivelli commented on a diff in pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#discussion_r904637026


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -114,12 +114,12 @@ public void getTenantNamespaces(@Suspended final AsyncResponse response,
     public void getTopics(@Suspended AsyncResponse response,
                           @PathParam("tenant") String tenant,
                           @PathParam("namespace") String namespace,
-                          @QueryParam("mode") @DefaultValue("PERSISTENT") Mode mode) {
+                          @QueryParam("mode") @DefaultValue("ALL") Mode mode) {

Review Comment:
   this is a breaking change
   
   I suspect it will give problems to the users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org