You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/07 20:33:44 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #1307: Fix struct comparison and add struct and partition set implementations
rdblue commented on a change in pull request #1307:
URL: https://github.com/apache/iceberg/pull/1307#discussion_r467256116
##########
File path: core/src/main/java/org/apache/iceberg/PartitionsTable.java
##########
@@ -95,15 +95,21 @@ private DataTask task(TableScan scan) {
}
}
- static class PartitionSet {
+ static class PartitionMap {
Review comment:
This was renamed to avoid a conflict with the new `PartitionSet` class, and updated to use `StructLikeWrapper` with correct `equals`/`hashCode` implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org