[GitHub] [superset] kgabryje edited a comment on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

[GitBox <gi...@apache.org>]

kgabryje edited a comment on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-763087513


   @ktmud That was my plan at first, but we keep current values of edited metrics in a state of component that is a sibling of popover title component (`AdhocMetricEditPopover`). So we'd have to either pass the state to a parent and down to popover title or move the edited metric's state to parent component (perhaps with Context API?). I thought that for now current solution would be sufficient and we could address "responsiveness" later as a separate issue. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org