You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/10/25 15:13:32 UTC

[GitHub] [cloudstack] khnazaretyan opened a new pull request #3651: Fix simulator docker db deploy issue (apache#3397)

khnazaretyan opened a new pull request #3651: Fix simulator docker db deploy issue (apache#3397)
URL: https://github.com/apache/cloudstack/pull/3651
 
 
   ## Description
   <!--- Describe your changes in detail -->
   As the latest docker image in dockerhub is built from master branch, I thought it would be correct to open PR into a master branch (and not to release, if inacceptable, please suggest the correct one).
   
   Fixes: #3397
   
   The latest cloudstack/simulator image is not working causing issue #3397. 
   The build was incomplete as mysql 5.7 is failing to start during docker build, thus DB is not deployed.
   The command `find /var/lib/mysql -type f -exec touch {} \;` is a workaround for the issue wich causes mysqld 5.7 to crash after start.
   Putting VOLUME instruction before starting mysql also solves this problem but does not allow any other changes to the folder during build.
   
   There are other also options that might be discussed:
   1. Setting `VOLUME /var/lib/mysql` instruction in Dockerfile and and importing the db during each container run (the start of the container will take longer).
   2. Try to download and install mysql v5.5 from archives during docker build (limited to 5.5)
   
   Other ideas/input will be much appreciated.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   Successfully built/run docker image/container according to the documentation.
   ```
   docker build -f Dockerfile -t cloudstack/simulator ../..
   docker run --name simulator -p 8080:8080 -d cloudstack/simulator
   ```
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services