You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/13 23:03:31 UTC

[GitHub] [spark] AlexMooney opened a new pull request #32153: Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

AlexMooney opened a new pull request #32153:
URL: https://github.com/apache/spark/pull/32153


   ### What changes were proposed in this pull request?
   
   Add a new line to the `lineSep` parameter so that the doc renders correctly.
   
   ### Why are the changes needed?
   
   > <img width="608" alt="image" src="https://user-images.githubusercontent.com/8269566/114631408-5c608900-9c71-11eb-8ded-ae1e21ae48b2.png">
   
   The first line of the description is part of the signature and is **bolded**.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, it changes how the docs for `pyspark.sql.DataFrameWriter.json` are rendered.
   
   ### How was this patch tested?
   
   I didn't test it; I don't have the doc rendering tool chain on my machine, but the change is obvious.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819205128


   **[Test build #137320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137320/testReport)** for PR 32153 at commit [`5969741`](https://github.com/apache/spark/commit/5969741e8ce60e0d4c938792be7e92b131e02282).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819241452


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819205128


   **[Test build #137320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137320/testReport)** for PR 32153 at commit [`5969741`](https://github.com/apache/spark/commit/5969741e8ce60e0d4c938792be7e92b131e02282).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819221112






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32153:
URL: https://github.com/apache/spark/pull/32153


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32153: Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819118002


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819215303


   Merged to master and branch-3.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819216781


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41900/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819118002


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819211187


   **[Test build #137320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137320/testReport)** for PR 32153 at commit [`5969741`](https://github.com/apache/spark/commit/5969741e8ce60e0d4c938792be7e92b131e02282).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32153: [MINOR][PYTHON][DOCS] Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819221112






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32153: Fix docstring for pyspark.sql.DataFrameWriter.json lineSep param

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32153:
URL: https://github.com/apache/spark/pull/32153#issuecomment-819204448


   Thanks @AlexMooney.
   
   Jenkins, ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org