You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2025/11/26 11:34:43 UTC
[PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
thisisnic opened a new pull request, #48262:
URL: https://github.com/apache/arrow/pull/48262
### Rationale for this change
We have bindings to stringr but stringr updated
### What changes are included in this PR?
Add new binding and warn re deprecation
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48262:
URL: https://github.com/apache/arrow/pull/48262#issuecomment-3649558430
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ad9279ecec34501d3788bdca5d219a625cf1b0e9.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/57976130856) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48262:
URL: https://github.com/apache/arrow/pull/48262#issuecomment-3580901493
:warning: GitHub issue #48127 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #48262:
URL: https://github.com/apache/arrow/pull/48262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #48262:
URL: https://github.com/apache/arrow/pull/48262#discussion_r2613293102
##########
r/tests/testthat/test-dplyr-funcs-string.R:
##########
@@ -899,51 +899,44 @@ test_that("str_like", {
collect(),
df
)
+
# with namespacing
compare_dplyr_binding(
.input |>
- mutate(x = stringr::str_like(x, "baz")) |>
+ mutate(x_like = stringr::str_like(x, "baz")) |>
+ mutate(x_ilike = stringr::str_ilike(x, "foo%")) |>
collect(),
df
)
# Match - entire string
compare_dplyr_binding(
.input |>
- mutate(x = str_like(x, "Foo and bar")) |>
+ mutate(x_like = str_like(x, "foo and bar")) |>
+ mutate(x_ilike = str_ilike(x, "foo and bar")) |>
Review Comment:
Yeah, the intention here was to differentiate between the two, as `str_like()` should return `FALSE` but `str_ilike()` should return `TRUE` as before stringr 1.6.0, `str_like()` was case-insensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48127: [R] stringr argument deprecation - add binding for stringr::str_ilike() and remove ignore_case argument for stringr::str_like() [arrow]
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #48262:
URL: https://github.com/apache/arrow/pull/48262#discussion_r2611951642
##########
r/tests/testthat/test-dplyr-funcs-string.R:
##########
@@ -899,51 +899,44 @@ test_that("str_like", {
collect(),
df
)
+
# with namespacing
compare_dplyr_binding(
.input |>
- mutate(x = stringr::str_like(x, "baz")) |>
+ mutate(x_like = stringr::str_like(x, "baz")) |>
+ mutate(x_ilike = stringr::str_ilike(x, "foo%")) |>
collect(),
df
)
# Match - entire string
compare_dplyr_binding(
.input |>
- mutate(x = str_like(x, "Foo and bar")) |>
+ mutate(x_like = str_like(x, "foo and bar")) |>
+ mutate(x_ilike = str_ilike(x, "foo and bar")) |>
Review Comment:
Is it relevant that the casing changed in the diff (capital F before)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org