You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/04/04 19:31:42 UTC
[GitHub] [airflow] eladkal opened a new pull request, #30467: add clarification about timezone aware dags
eladkal opened a new pull request, #30467:
URL: https://github.com/apache/airflow/pull/30467
I've heard from several users that recent time change in Mexico caused DAGs not to run as expected.
This PR add clarification about such cases.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] notatallshaw-gts commented on pull request #30467: add clarification about timezone aware dags
Posted by "notatallshaw-gts (via GitHub)" <gi...@apache.org>.
notatallshaw-gts commented on PR #30467:
URL: https://github.com/apache/airflow/pull/30467#issuecomment-1498038175
Sorry to comment on a merged PR but it appears to be the issue is there is no version of Pendulum which includes the recent changes to DST in Mexico. Some discussion has started happening here https://github.com/sdispater/pendulum/issues/700 (not sure there is a conclusion yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #30467: add clarification about timezone aware dags
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #30467:
URL: https://github.com/apache/airflow/pull/30467#issuecomment-1505676443
> Sorry to comment on a merged PR but it appears to be the issue is there is no released version of Pendulum which includes the recent changes to DST in Mexico.
Thus this is upstream library problem, nothing we can do about it other than waiting for them to fix it.
Once they will issue a release with a fix it will be up to Airflow to see how we can migrate to the new release as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #30467: add clarification about timezone aware dags
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #30467:
URL: https://github.com/apache/airflow/pull/30467#discussion_r1157845180
##########
docs/apache-airflow/authoring-and-scheduling/timezone.rst:
##########
@@ -150,6 +150,13 @@ date will be converted to UTC using the timezone associated with ``start_date``
or ``end_date``, then for calculations this timezone information will be
disregarded.
+.. note::
+ When authoring Timezone aware DAG you must make sure that the underlying timezone library (for example: pendulum)
+ is updated with changes to regulations (daylight saving changes etc...). When moving time
+ is expected you should verify with the underlying timezone library that switch will happen as expected.
+ There might be a need to update the library version. As a general recommendation if you can author DAGs in UTC
+ that is preferred.
Review Comment:
```suggestion
When authoring a Timezone aware DAG you must make sure that the underlying timezone library (for example: pendulum)
is updated with recent changes to regulations (daylight saving changes etc...). When a change in time
is expected you should verify with the underlying timezone library that the switch will happen as expected.
There might be a need to update the library version. As a general recommendation if you can author DAGs in UTC
that is preferred.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #30467: add clarification about timezone aware dags
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #30467:
URL: https://github.com/apache/airflow/pull/30467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org