You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2026/07/17 01:46:55 UTC
[PR] KAFKA-20808: StreamThread dies with fatal InvalidStateStoreException after TaskCorruptedException [kafka]
mjsax opened a new pull request, #22855:
URL: https://github.com/apache/kafka/pull/22855
This PR ensures that an unsuccessfully opened segment is remove from the in-memory cache for open segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20808: StreamThread dies with fatal InvalidStateStoreException after TaskCorruptedException [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #22855:
URL: https://github.com/apache/kafka/pull/22855#issuecomment-5006902068
Merged to `trunk` and cherry-picked to `4.3` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20808: StreamThread dies with fatal InvalidStateStoreException after TaskCorruptedException [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #22855:
URL: https://github.com/apache/kafka/pull/22855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20808: StreamThread dies with fatal InvalidStateStoreException after TaskCorruptedException [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #22855:
URL: https://github.com/apache/kafka/pull/22855#discussion_r3604736310
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##########
@@ -96,7 +96,12 @@ public S getOrCreateSegment(final long segmentId,
throw new IllegalStateException(newSegment.getClass().getSimpleName() + " already exists. Possible concurrent access.");
}
- openSegmentDB(newSegment, context);
+ try {
+ openSegmentDB(newSegment, context);
+ } catch (final Exception openException) {
+ segments.remove(segmentId);
Review Comment:
I don't think we need to log anything? We re-throw the exception unmodified, so we don't lose anything, and upper layer will so some logging for it. -- And we should not double log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20808: StreamThread dies with fatal InvalidStateStoreException after TaskCorruptedException [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #22855:
URL: https://github.com/apache/kafka/pull/22855#discussion_r3604377530
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##########
@@ -96,7 +96,12 @@ public S getOrCreateSegment(final long segmentId,
throw new IllegalStateException(newSegment.getClass().getSimpleName() + " already exists. Possible concurrent access.");
}
- openSegmentDB(newSegment, context);
+ try {
+ openSegmentDB(newSegment, context);
+ } catch (final Exception openException) {
+ segments.remove(segmentId);
Review Comment:
Does it buy anything to log here or will the act of throwing capture the details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org