You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:45:23 UTC
[GitHub] [helix] NealSun96 opened a new pull request #821: Fix
InvalidRoutingData error message in tests
NealSun96 opened a new pull request #821: Fix InvalidRoutingData error message in tests
URL: https://github.com/apache/helix/pull/821
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #820
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR aims to fix the `InvalidRoutingDataException` error message that shows up in tests. The source of this error was due to two test cases in `TestZkMetadataStoreDirectory`, in which both of the test cases inserted "/a/b/c/d/e" directly into the same set of routing data. This renders the routing data invalid because one sharding key is pointing to two realms.
This was not caught at insertion because the insertion was done directly instead of through a dedicated API (because the code in question is a test case). The tests didn't fail because they relied on the raw routing data for correctness. The construction of `MetadataStoreRoutingData` failed "correctly" as can be seen from the error messages, however the construction failure was after raw routing data being fetched, therefore making the situation undetected.
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 128, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.796 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 128, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.357 s
[INFO] Finished at: 2020-02-26T16:33:30-08:00
[INFO] ------------------------------------------------------------------------
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on issue #821: Fix InvalidRoutingData
error message in tests
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on issue #821: Fix InvalidRoutingData error message in tests
URL: https://github.com/apache/helix/pull/821#issuecomment-591728078
This PR is ready to be merged, approved by @narendly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #821: Fix InvalidRoutingData
error message in tests
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #821: Fix InvalidRoutingData error message in tests
URL: https://github.com/apache/helix/pull/821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org