You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/23 02:15:30 UTC
[GitHub] [shardingsphere] clbigdata opened a new pull request #16280: ClusterContextManagerCoordinator.renew(final InstanceOfflineEvent eve…
clbigdata opened a new pull request #16280:
URL: https://github.com/apache/shardingsphere/pull/16280
…nt) need add unit test. #16088
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on a change in pull request #16280: ClusterContextManagerCoordinator.renew(final InstanceOfflineEvent eve…
Posted by GitBox <gi...@apache.org>.
zjcnb commented on a change in pull request #16280:
URL: https://github.com/apache/shardingsphere/pull/16280#discussion_r832801524
##########
File path: shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/ClusterContextManagerCoordinatorTest.java
##########
@@ -295,14 +296,21 @@ public void assertRenewInstanceLabels() {
coordinator.renew(mockLabelsEvent);
assertThat(contextManager.getInstanceContext().getInstance().getLabels(), is(labels));
}
-
+
Review comment:
Please keep original style.
##########
File path: shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/ClusterContextManagerCoordinatorTest.java
##########
@@ -279,14 +280,14 @@ public void assertRenewInstanceStatus() {
coordinator.renew(mockStateEvent);
assertThat(contextManager.getInstanceContext().getInstance().getState().getCurrentState(), is(StateType.CIRCUIT_BREAK));
}
-
+
@Test
public void assertRenewWorkerIdChange() {
WorkerIdEvent mockWorkerIdEvent = new WorkerIdEvent(contextManager.getInstanceContext().getInstance().getInstanceDefinition().getInstanceId().getId(), 12223L);
coordinator.renew(mockWorkerIdEvent);
assertThat(contextManager.getInstanceContext().getWorkerId(), is(12223L));
}
-
+
Review comment:
Please keep original style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] clbigdata closed pull request #16280: ClusterContextManagerCoordinator.renew(final InstanceOfflineEvent eve…
Posted by GitBox <gi...@apache.org>.
clbigdata closed pull request #16280:
URL: https://github.com/apache/shardingsphere/pull/16280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org