You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/06/09 00:59:11 UTC
Review Request 35230: RANGER-538: updated REST methods to send the
error details back to the caller (Ranger Admin UI)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35230/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-538
https://issues.apache.org/jira/browse/RANGER-538
Repository: ranger
Description
-------
RANGER-538: updated REST methods to send the error details back to the caller (Ranger Admin UI)
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java a17da9b
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 7c2bbdc
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 16528bd
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f9464ec
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java f024b99
Diff: https://reviews.apache.org/r/35230/diff/
Testing
-------
Verified that errors during service create/update are displayed in Ranger Admin UI. However, changes to ranger-admin UI might be needed to show the error details during policy create/update.
Thanks,
Madhan Neethiraj
Re: Review Request 35230: RANGER-538: updated REST methods to send
the error details back to the caller (Ranger Admin UI)
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35230/#review87334
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
<https://reviews.apache.org/r/35230/#comment139670>
Can we change this to catch Throwable instead of Exception
- Selvamohan Neethiraj
On June 8, 2015, 6:59 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35230/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 6:59 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-538
> https://issues.apache.org/jira/browse/RANGER-538
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-538: updated REST methods to send the error details back to the caller (Ranger Admin UI)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java a17da9b
> security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 7c2bbdc
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 16528bd
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f9464ec
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java f024b99
>
> Diff: https://reviews.apache.org/r/35230/diff/
>
>
> Testing
> -------
>
> Verified that errors during service create/update are displayed in Ranger Admin UI. However, changes to ranger-admin UI might be needed to show the error details during policy create/update.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 35230: RANGER-538: updated REST methods to send
the error details back to the caller (Ranger Admin UI)
Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35230/#review87339
-----------------------------------------------------------
Ship it!
Ship It!
- Selvamohan Neethiraj
On June 9, 2015, 9:51 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35230/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 9:51 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-538
> https://issues.apache.org/jira/browse/RANGER-538
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-538: updated REST methods to send the error details back to the caller (Ranger Admin UI)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 16528bd
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f9464ec
>
> Diff: https://reviews.apache.org/r/35230/diff/
>
>
> Testing
> -------
>
> Verified that errors during service create/update are displayed in Ranger Admin UI. However, changes to ranger-admin UI might be needed to show the error details during policy create/update.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 35230: RANGER-538: updated REST methods to send
the error details back to the caller (Ranger Admin UI)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35230/
-----------------------------------------------------------
(Updated June 10, 2015, 1:51 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Address the review comment.
Bugs: RANGER-538
https://issues.apache.org/jira/browse/RANGER-538
Repository: ranger
Description
-------
RANGER-538: updated REST methods to send the error details back to the caller (Ranger Admin UI)
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 16528bd
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java f9464ec
Diff: https://reviews.apache.org/r/35230/diff/
Testing
-------
Verified that errors during service create/update are displayed in Ranger Admin UI. However, changes to ranger-admin UI might be needed to show the error details during policy create/update.
Thanks,
Madhan Neethiraj