You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by Rishindra Kumar <ri...@gmail.com> on 2019/08/19 06:10:08 UTC

Review of pull request

Hi,

I created pull request with the change I proposed in the comment. Could
someone please review it?
https://github.com/apache/flink/pull/9468

-- 
*Maddila Rishindra Kumar*
*Software Engineer*
*Walmartlabs India*
*Contact No: +919967379528 | Alternate E-mail
ID: rishindra.maddila@walmartlabs.com <ri...@walmartlabs.com>*

Re: Review of pull request

Posted by Rishindra Kumar <ri...@gmail.com>.

Hi Gordon,

I modified the change according to your suggestions and updated the pull
request. I am awaiting your review. Could you please review it when you get
time?


-- 
*Maddila Rishindra Kumar*
*Software Engineer*
*Walmartlabs India*
*Contact No: +919967379528 | Alternate E-mail
ID: rishindra.maddila@walmartlabs.com <ri...@walmartlabs.com>*

Re: Review of pull request

Posted by Rishindra Kumar <ri...@gmail.com>.

Thank you Gordon. I will have a look.

-- 
*Maddila Rishindra Kumar*
*Software Engineer*
*Walmartlabs India*
*Contact No: +919967379528 | Alternate E-mail
ID: rishindra.maddila@walmartlabs.com <ri...@walmartlabs.com>*

Re: Review of pull request

Posted by "Tzu-Li (Gordon) Tai" <tz...@apache.org>.

Hi Rishindra,

Thanks for the pull request. I've left a comment on it.

Cheers,
Gordon

On Mon, Aug 19, 2019 at 10:16 AM Till Rohrmann <tr...@apache.org> wrote:

> Hi Rishindra,
>
> I've pulled in Gordon who has worked on the Elasticsearch connector. He
> might be able to review the PR.
>
> Cheers,
> Till
>
> On Mon, Aug 19, 2019 at 8:10 AM Rishindra Kumar <
> rishindrakumar55@gmail.com> wrote:
>
>> Hi,
>>
>> I created pull request with the change I proposed in the comment. Could
>> someone please review it?
>> https://github.com/apache/flink/pull/9468
>>
>> --
>> *Maddila Rishindra Kumar*
>> *Software Engineer*
>> *Walmartlabs India*
>> *Contact No: +919967379528 | Alternate E-mail
>> ID: rishindra.maddila@walmartlabs.com <rishindra.maddila@walmartlabs.com
>> >*
>>
>

Re: Review of pull request

Posted by Till Rohrmann <tr...@apache.org>.

Hi Rishindra,

I've pulled in Gordon who has worked on the Elasticsearch connector. He
might be able to review the PR.

Cheers,
Till

On Mon, Aug 19, 2019 at 8:10 AM Rishindra Kumar <ri...@gmail.com>
wrote:

> Hi,
>
> I created pull request with the change I proposed in the comment. Could
> someone please review it?
> https://github.com/apache/flink/pull/9468
>
> --
> *Maddila Rishindra Kumar*
> *Software Engineer*
> *Walmartlabs India*
> *Contact No: +919967379528 | Alternate E-mail
> ID: rishindra.maddila@walmartlabs.com <ri...@walmartlabs.com>*
>