Re: Changes to the collection do not persist. Cache and ObjectEnvelope problem?

[Thomas Mahler <th...@web.de>]

Hi all,

David is right, I reviewed his patch before rc2 and did not check it in 
because it caused additional testcase failures. I am now reviewing the 
patch again and hope to fix the negative side effects too.

David is also right about the resource problem. I'm currently absorbed 
by a project that allows me to spend only little time on OJB.

BTW I think the correct if clause should be:
if ( ( items instanceof CollectionProxy)
  &&
    (! ((CollectionProxy) items).isLoaded()))

I'll keep you updated...
cheers,
Thomas

Brian McCallister wrote:
> 
> On Wednesday, April 30, 2003, at 04:01 PM, David.Corbin@equifax.com wrote:
> 
>>                    /*
>>                      * if items are a collectionproxy, and it's not 
>> already
>> loaded, don't register it.
>>                      */
>>                     if (!(!( items instanceof CollectionProxy) ||
>> ( (CollectionProxy) items).isLoaded()))
>>                     {
>>                             continue;
>>                     }
>>
> 
> if ((items intanceof CollectionProxy) && 
> (((CollectionProxy)items).isLoaded()))
> 
> At least it matches the comment and resolves the same. instanceof scares 
> me, though.
> 
> -Brian
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-user-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-user-help@db.apache.org
> 
>