You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2016/07/05 15:07:11 UTC
[jira] [Comment Edited] (SOLR-9277) Clean up some more remnants of
supporting old and new style solr.xml in tests
[ https://issues.apache.org/jira/browse/SOLR-9277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361895#comment-15361895 ]
Erick Erickson edited comment on SOLR-9277 at 7/5/16 3:07 PM:
--------------------------------------------------------------
[~noble.paul] [~ichattopadhyaya] [~markrmiller@gmail.com] Mostly throwing this out for discussion, any off-the-top-of-your-head comments? Perhaps make the vars like autoReplicaFailoverBadNodeExpiration into some kind of default and set sys props as necessary?
NOTE: I really haven't dug into this at _all_ (doing so now). This is mostly a marker.
was (Author: erickerickson):
[~noble.paul] [~ichattopadhyaya] [~markrmiller@gmail.com] Mostly throwing this out for discussion, any off-the-top-of-your-head comments? Perhaps amek the vars like autoReplicaFailoverBadNodeExpiration into some kind of default and set sys props as necessary?
NOTE: I really haven't dug into this at _all_ (doing so now). This is mostly a marker.
> Clean up some more remnants of supporting old and new style solr.xml in tests
> -----------------------------------------------------------------------------
>
> Key: SOLR-9277
> URL: https://issues.apache.org/jira/browse/SOLR-9277
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> I have reason to look at the tests and I'm seeing a few remnants of old/new style Solr.xml support (with and without <cores>). So far:
> > SolrTestCaseJ4.copySolrHomeToTemp with a flag whether old or new style.
> > solr-no-core.xml in test files. Mostly this is identical to solr.xml, here are the differences:
> in solr-no-core.xml but not solr.xml
> <int name="autoReplicaFailoverWaitAfterExpiration">${autoReplicaFailoverWaitAfterExpiration:10000}</int>
> <int name="autoReplicaFailoverWorkLoopDelay">${autoReplicaFailoverWorkLoopDelay:10000}</int>
> <int name="autoReplicaFailoverBadNodeExpiration">${autoReplicaFailoverBadNodeExpiration:60000}</int>
> in solr.xml but not in solr-no-cores.xml:
> <int name="leaderVoteWait">${leaderVoteWait:10000}</int>
> The question here is whether putting the three properties in solr-no-cores.xml would mess up tests using solr.xml and whether leaderVoteWait being in solr.xml would mess up tests using solr-no-cores.xml.
> I'll make a quick hack at this to see and we can discuss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org