You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/02 05:28:06 UTC

[GitHub] [yunikorn-core] bgrams commented on pull request #463: [YUNIKORN-1440] Cleanup terminated applications once expired

bgrams commented on PR #463:
URL: https://github.com/apache/yunikorn-core/pull/463#issuecomment-1334780956

   > Looking at the TestCleanupCompletedApps it is even more broken than what you have fixed.
   > 
   > The proper test should have two apps in the `completedApplications` map. One is in the Completed state, and the second one is in the Expired state. Running the cleanupExpiredApps() should remove one and not the other. Both apps should have moved from Completing to Completed using the event. The `partition.applications` list should be 2 before the events and 0 after the events. Vice versa for the `partition.completedApplications` list
   
   Addressed in [26e126a](https://github.com/apache/yunikorn-core/pull/463/commits/26e126a649331bac065b146e3bd08c9793e7f8ac)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org